third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc - Issue 2676533003: [LayoutNG] Convert physical fragments to being RefCounted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc

Issue 2676533003: [LayoutNG] Convert physical fragments to being RefCounted. (Closed)

Patch Set: address comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc b/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc

index 34f3f3f9d8ae23842ff7a1d02091854a84918004..3e40fdb61eab89a881bffda93b3dc40258f8e898 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_inline_node.cc

@@ -215,7 +215,7 @@ void NGInlineNode::ShapeText() {

}

-NGPhysicalFragment* NGInlineNode::Layout(NGConstraintSpace*) {

+RefPtr<NGPhysicalFragment> NGInlineNode::Layout(NGConstraintSpace*) {

ASSERT_NOT_REACHED();

return nullptr;

}