Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2676333002: Revert "Box shadow should be recorded as main thread scrolling reasons for non-root layers." (Closed)

Created:
3 years, 10 months ago by yigu
Modified:
3 years, 10 months ago
Reviewers:
bokan, ajuma, jwd
CC:
chromium-reviews, szager+layoutwatch_chromium.org, asvitkine+watch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, cc-bugs_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bisect job found this CL several times suspecting that it caused regression on nexus5p(crbug.com/685182). Revert it for now. This reverts commit c83ddee4e5dcb0fdce873021c2701c9c3a2c547a. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2676333002 Cr-Commit-Position: refs/heads/master@{#448326} Committed: https://chromium.googlesource.com/chromium/src/+/95d4abb16bc2444b187772d3a4ee461503d4b7a7

Patch Set 1 #

Patch Set 2 : Keep histograms.xml as is to avoid messing up enum numbers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -60 lines) Patch
M cc/input/main_thread_scrolling_reason.h View 4 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 3 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.h View 1 chunk +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 4 chunks +14 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/data/two_scrollable_area.html View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676333002/1
3 years, 10 months ago (2017-02-06 16:29:01 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-06 16:29:02 UTC) #6
ajuma
On 2017/02/06 16:29:02, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 10 months ago (2017-02-06 16:35:31 UTC) #10
bokan
lgtm
3 years, 10 months ago (2017-02-06 16:38:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2676333002/20001
3 years, 10 months ago (2017-02-06 16:44:55 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/95d4abb16bc2444b187772d3a4ee461503d4b7a7
3 years, 10 months ago (2017-02-06 18:48:40 UTC) #17
yigu
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2681773003/ by yigu@chromium.org. ...
3 years, 10 months ago (2017-02-07 20:43:09 UTC) #18
bokan
3 years, 10 months ago (2017-02-07 20:51:30 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2685653003/ by bokan@chromium.org.

The reason for reverting is: Reverted patch wasn't responsible for regression..

Powered by Google App Engine
This is Rietveld 408576698