Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 2676333002: Revert "Box shadow should be recorded as main thread scrolling reasons for non-root layers." (Closed)
Patch Set: Keep histograms.xml as is to avoid messing up enum numbers Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
494 494
495 // Returns the GraphicsLayer owned by this PaintLayer's 495 // Returns the GraphicsLayer owned by this PaintLayer's
496 // CompositedLayerMapping (or groupedMapping()'s, if squashed), 496 // CompositedLayerMapping (or groupedMapping()'s, if squashed),
497 // into which the given LayoutObject paints. If null, assumes the 497 // into which the given LayoutObject paints. If null, assumes the
498 // LayoutObject is *not* layoutObject(). 498 // LayoutObject is *not* layoutObject().
499 // Assumes that the given LayoutObject paints into one of the GraphicsLayers 499 // Assumes that the given LayoutObject paints into one of the GraphicsLayers
500 // associated with this PaintLayer. 500 // associated with this PaintLayer.
501 // Returns nullptr if this PaintLayer is not composited. 501 // Returns nullptr if this PaintLayer is not composited.
502 GraphicsLayer* graphicsLayerBacking(const LayoutObject* = nullptr) const; 502 GraphicsLayer* graphicsLayerBacking(const LayoutObject* = nullptr) const;
503 503
504 // TODO(yigu): PaintLayerScrollableArea::computeNeedsCompositedScrolling 504 BackgroundPaintLocation backgroundPaintLocation() const;
505 // calls this method to obtain main thread scrolling reasons due to
506 // background paint location. Once the cases get handled on compositor the
507 // parameter "reasons" could be removed.
508 BackgroundPaintLocation backgroundPaintLocation(
509 uint32_t* reasons = nullptr) const;
510 // NOTE: If you are using hasCompositedLayerMapping to determine the state of 505 // NOTE: If you are using hasCompositedLayerMapping to determine the state of
511 // compositing for this layer, (and not just to do bookkeeping related to the 506 // compositing for this layer, (and not just to do bookkeeping related to the
512 // mapping like, say, allocating or deallocating a mapping), then you may have 507 // mapping like, say, allocating or deallocating a mapping), then you may have
513 // incorrect logic. Use compositingState() instead. 508 // incorrect logic. Use compositingState() instead.
514 // FIXME: This is identical to null checking compositedLayerMapping(), why not 509 // FIXME: This is identical to null checking compositedLayerMapping(), why not
515 // just call that? 510 // just call that?
516 bool hasCompositedLayerMapping() const { 511 bool hasCompositedLayerMapping() const {
517 return m_rareData && m_rareData->compositedLayerMapping; 512 return m_rareData && m_rareData->compositedLayerMapping;
518 } 513 }
519 void ensureCompositedLayerMapping(); 514 void ensureCompositedLayerMapping();
(...skipping 734 matching lines...) Expand 10 before | Expand all | Expand 10 after
1254 1249
1255 } // namespace blink 1250 } // namespace blink
1256 1251
1257 #ifndef NDEBUG 1252 #ifndef NDEBUG
1258 // Outside the WebCore namespace for ease of invocation from gdb. 1253 // Outside the WebCore namespace for ease of invocation from gdb.
1259 CORE_EXPORT void showLayerTree(const blink::PaintLayer*); 1254 CORE_EXPORT void showLayerTree(const blink::PaintLayer*);
1260 CORE_EXPORT void showLayerTree(const blink::LayoutObject*); 1255 CORE_EXPORT void showLayerTree(const blink::LayoutObject*);
1261 #endif 1256 #endif
1262 1257
1263 #endif // Layer_h 1258 #endif // Layer_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698