Remove some unnecessary calls to TestingProfile::DestroyHistoryService

Remove some unnecessary calls to TestingProfile::DestroyHistoryService

Explicitly destroying the HistoryService may leave dependent services
with dangling pointers, and is generally not required (it'll get
destroyed during profile shutdown anyway).

This also adds a warning to TestingProfile::CreateHistoryService and
DestroyHistoryService, since they're generally not safe to use.

BUG=689055
Review-Url: https://codereview.chromium.org/2676303002
Cr-Commit-Position: refs/heads/master@{#448574}
Committed: https://chromium.googlesource.com/chromium/src/+/d8eebb4748e2c2bc2efe5bbcfd6a0d8fa0d0ddd4

[Marc Treib, 2017-02-06 16:11:29]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 16:11:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 16:55:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 16:55:40]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2017-02-06 17:11:27]

treib@chromium.org changed reviewers:
+ sky@chromium.org

[Marc Treib, 2017-02-06 17:11:27]

PTAL, in particular at the comments I added in testing_profile.h. Some more
context is on the bug.

https://codereview.chromium.org/2676303002/diff/1/chrome/browser/ui/toolbar/b...
File chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc (left):

https://codereview.chromium.org/2676303002/diff/1/chrome/browser/ui/toolbar/b...
chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc:568: // This is
required to prevent the message loop from hanging.
This doesn't seem to be true anymore, which is plausible given that this line
was written back in 2011 (did we even have the BrowserContextDependencyManager
back then?)

[sky, 2017-02-06 18:01:00]

LGTM

[Marc Treib, 2017-02-07 08:56:32]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2017-02-07 08:56:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 09:00:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486457792362940, "parent_rev":
"28ac5a462c714b6cd7fda6e8d433723d3bcbe9f3", "commit_rev":
"d8eebb4748e2c2bc2efe5bbcfd6a0d8fa0d0ddd4"}

[commit-bot: I haz the power, 2017-02-07 09:01:32]

Description was changed from

==========
Remove some unnecessary calls to TestingProfile::DestroyHistoryService

Explicitly destroying the HistoryService may leave dependent services
with dangling pointers, and is generally not required (it'll get
destroyed during profile shutdown anyway).

This also adds a warning to TestingProfile::CreateHistoryService and
DestroyHistoryService, since they're generally not safe to use.

BUG=689055
==========

to

==========
Remove some unnecessary calls to TestingProfile::DestroyHistoryService

Explicitly destroying the HistoryService may leave dependent services
with dangling pointers, and is generally not required (it'll get
destroyed during profile shutdown anyway).

This also adds a warning to TestingProfile::CreateHistoryService and
DestroyHistoryService, since they're generally not safe to use.

BUG=689055

Review-Url: https://codereview.chromium.org/2676303002
Cr-Commit-Position: refs/heads/master@{#448574}
Committed:
https://chromium.googlesource.com/chromium/src/+/d8eebb4748e2c2bc2efe5bbcfd6a...
==========

[commit-bot: I haz the power, 2017-02-07 09:01:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d8eebb4748e2c2bc2efe5bbcfd6a...