Remove some unnecessary calls to TestingProfile::DestroyHistoryService

chrome/test/base/testing_profile.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_BASE_TESTING_PROFILE_H_
 #define CHROME_TEST_BASE_TESTING_PROFILE_H_
 
 #include <memory>
 #include <string>
 #include <utility>
@@ skipping 160 matching lines @@
                  const std::string& supervised_user_id,
                  std::unique_ptr<policy::PolicyService> policy_service,
                  const TestingFactories& factories,
                  const std::string& profile_name);
 
   ~TestingProfile() override;
 
   // Creates the favicon service. Consequent calls would recreate the service.
   void CreateFaviconService();
 
+  // !!!!!!!! WARNING: THIS IS GENERALLY NOT SAFE TO CALL! !!!!!!!!
+  // This bypasses the BrowserContextDependencyManager, and in particular, it
+  // destroys any previously-created HistoryService. That means any other
+  // KeyedServices that depend on HistoryService may be left with dangling
+  // pointers.
+  // Instead, use Builder::AddTestingFactory to inject your own factories.
+  // !!!!!!!! WARNING: THIS IS GENERALLY NOT SAFE TO CALL! !!!!!!!!
   // Creates the history service. If |delete_file| is true, the history file is
   // deleted first, then the HistoryService is created. As TestingProfile
   // deletes the directory containing the files used by HistoryService, this
   // only matters if you're recreating the HistoryService.  If |no_db| is true,
   // the history backend will fail to initialize its database; this is useful
   // for testing error conditions. Returns true on success.
   bool CreateHistoryService(bool delete_file, bool no_db) WARN_UNUSED_RESULT;
 
+  // !!!!!!!! WARNING: THIS IS GENERALLY NOT SAFE TO CALL! !!!!!!!!
+  // This bypasses the BrowserContextDependencyManager and thus may leave other
+  // KeyedServices with dangling pointers; see above. It's also usually not
+  // necessary to explicitly destroy the HistoryService; it'll be destroyed
+  // along with the TestingProfile anyway.
+  // !!!!!!!! WARNING: THIS IS GENERALLY NOT SAFE TO CALL! !!!!!!!!
   // Shuts down and nulls out the reference to HistoryService.
   void DestroyHistoryService();
 
   // Creates the BookmarkBarModel. If not invoked the bookmark bar model is
   // NULL. If |delete_file| is true, the bookmarks file is deleted first, then
   // the model is created. As TestingProfile deletes the directory containing
   // the files used by HistoryService, the boolean only matters if you're
   // recreating the BookmarkModel.
   //
   // NOTE: this does not block until the bookmarks are loaded. For that use
@@ skipping 215 matching lines @@
 
   // Weak pointer to a delegate for indicating that a profile was created.
   Delegate* delegate_;
 
   std::string profile_name_;
 
   std::unique_ptr<policy::PolicyService> policy_service_;
 };
 
 #endif  // CHROME_TEST_BASE_TESTING_PROFILE_H_