Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2675993002: [runtime] Fix use of attributes if intercepted. (Closed)

Created:
3 years, 10 months ago by Franzi
Modified:
3 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Fix use of attributes if intercepted. The property details of a LookupIterator are not accessible, if the iterator state is interceptor. Instead, use the property attributes. Fixes a crash in Node.js tests in Debug mode, see https://github.com/nodejs/node/commit/c2c6ae52eaf302da9c106699b69d17c083ced316 BUG= Review-Url: https://codereview.chromium.org/2675993002 Cr-Commit-Position: refs/heads/master@{#42941} Committed: https://chromium.googlesource.com/v8/v8/+/29e8d49f564af8be987f8b9112e2d2a0115daeea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -2 lines) Patch
M src/runtime/runtime-scopes.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
Franzi
PTAL.
3 years, 10 months ago (2017-02-04 12:40:15 UTC) #7
Yang
On 2017/02/04 12:40:15, Franzi wrote: > PTAL. lgtm
3 years, 10 months ago (2017-02-04 15:52:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675993002/1
3 years, 10 months ago (2017-02-04 16:28:28 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-04 16:30:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/29e8d49f564af8be987f8b9112e2d2a0115...

Powered by Google App Engine
This is Rietveld 408576698