Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2674103002: [runtime] Skip feedback vector configuration. (Closed)

Created:
3 years, 10 months ago by Franzi
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Skip vector config for interceptors. Do not preinitialize the feedback vector slot if the lookup iterator is an interceptor, because it is not guaranteed that the iterator has a PropertyCell. If the HandlerConfiguration has a non-masking intercepting setter, the iterator does not have a valid PropertyCell. BUG=chromium:656648 Review-Url: https://codereview.chromium.org/2674103002 Cr-Commit-Position: refs/heads/master@{#43034} Committed: https://chromium.googlesource.com/v8/v8/+/0c137304e6e9ff6d6e627260f2877ba1944738c4

Patch Set 1 #

Patch Set 2 : Add regression test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -1 line) Patch
M src/runtime/runtime-scopes.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 2 chunks +25 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (15 generated)
Franzi
Hi Jochen, Please take a look. Thanks, Franzi
3 years, 10 months ago (2017-02-06 09:35:25 UTC) #8
jochen (gone - plz use gerrit)
is it possible to write a test for this?
3 years, 10 months ago (2017-02-07 15:07:37 UTC) #9
Franzi
On 2017/02/07 15:07:37, jochen wrote: > is it possible to write a test for this? ...
3 years, 10 months ago (2017-02-08 11:37:06 UTC) #15
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-08 11:38:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674103002/20001
3 years, 10 months ago (2017-02-08 11:43:35 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 11:50:07 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/0c137304e6e9ff6d6e627260f2877ba1944...

Powered by Google App Engine
This is Rietveld 408576698