Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issue 2675973004: Update NT2 name to be the requested URL instead of 'document' (Closed)

Created:
3 years, 10 months ago by panicker
Modified:
3 years, 10 months ago
Reviewers:
haraken, Yoav Weiss, sunjian
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update NT2 name to be the requested URL instead of 'document' There's a strong request to merge this in M57, see spec bug: https://github.com/w3c/navigation-timing/issues/59 BUG=675039 Review-Url: https://codereview.chromium.org/2675973004 Cr-Commit-Position: refs/heads/master@{#448517} Committed: https://chromium.googlesource.com/chromium/src/+/0af62af4bf7a7b092fd5d81acc56e316a01244db

Patch Set 1 #

Patch Set 2 : fix failing wpt tests (imported after creation of this CL), and delete a redundant, old test #

Messages

Total messages: 16 (10 generated)
panicker
PTAL
3 years, 10 months ago (2017-02-04 00:50:04 UTC) #2
haraken
LGTM Maybe you need to get an approval from an API owner since this is ...
3 years, 10 months ago (2017-02-04 09:35:56 UTC) #4
sunjian
On 2017/02/04 09:35:56, haraken wrote: > LGTM > > Maybe you need to get an ...
3 years, 10 months ago (2017-02-06 18:56:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675973004/20001
3 years, 10 months ago (2017-02-07 00:29:02 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/0af62af4bf7a7b092fd5d81acc56e316a01244db
3 years, 10 months ago (2017-02-07 02:28:44 UTC) #15
Yoav Weiss
3 years, 10 months ago (2017-02-07 08:03:11 UTC) #16
Message was sent while issue was closed.
On 2017/02/07 02:28:44, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/chromium/src/+/0af62af4bf7a7b092fd5d81acc56...

retroactive LGTM

Powered by Google App Engine
This is Rietveld 408576698