third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_instance_accessors.html - Issue 2675973004: Update NT2 name to be the requested URL instead of 'document'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_instance_accessors.html

Issue 2675973004: Update NT2 name to be the requested URL instead of 'document' (Closed)

Patch Set: fix failing wpt tests (imported after creation of this CL), and delete a redundant, old test Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_attributes_values.html ('k') | third_party/WebKit/Source/core/timing/PerformanceBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_instance_accessors.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_instance_accessors.html b/third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_instance_accessors.html

index cf478b955b1c142bde378a439e3f7a11c90f28eb..77750c2dcbe86476357cea83bccaa6655ba4764e 100644

--- a/third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_instance_accessors.html

+++ b/third_party/WebKit/LayoutTests/http/tests/w3c/webperf/approved/navigation-timing/html/nav2_test_instance_accessors.html

@@ -10,7 +10,7 @@

</head>

<body>

<h1>Description</h1>

- <p>This test validates that nav timing 2 instance can be accessed by three different accessors once available: window.performance.getEntries()/getEntriesByType("navigation")/getEntriesByName("document")</p>

+ <p>This test validates that nav timing 2 instance can be accessed by three different accessors once available: window.performance.getEntries()/getEntriesByType("navigation")/getEntriesByName("<Requested URL>")</p>

var navTiming2Attributes = [

@@ -50,10 +50,10 @@

t.step_func(function (entryList) {

var instance1 = performance.getEntries()[0];

var instance2 = performance.getEntriesByType("navigation")[0];

- var instance3 = performance.getEntriesByName("document")[0];

+ var instance3 = performance.getEntriesByName("http://127.0.0.1:8000/w3c/webperf/approved/navigation-timing/html/nav2_test_instance_accessors.html")[0];

assert_equals(performance.getEntriesByType("navigation").length, 1, "Expected there is only one navigation timing instance.");

- assert_equals(performance.getEntriesByName("document").length, 1, "Expected there is only one navigation timing instance.");

+ assert_equals(performance.getEntriesByName("http://127.0.0.1:8000/w3c/webperf/approved/navigation-timing/html/nav2_test_instance_accessors.html").length, 1, "Expected there is only one navigation timing instance.");

for (var i = 0; i < navTiming2Attributes.length; i++) {

assert_equals(instance1[navTiming2Attributes[i]], instance2[navTiming2Attributes[i]]);