Issue 2675903002: Revert of Update component updater URLs.

Issue 2675903002: Revert of Update component updater URLs. (Closed)

Created:
3 years, 10 months ago by dtu

Modified:
3 years, 10 months ago

Reviewers:
waffles, Sorin Jianu, pastarmovj, rkaplow

CC:
chromium-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Update component updater URLs. (patchset #2 id:20001 of https://codereview.chromium.org/2654033009/ ) Reason for revert: Lots of perf benchmarks started failing on Android. Bisect pointed to this change. https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%20%281%29/builds/5173 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%20%281%29/builds/4443 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%20%281%29/builds/4826 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf%20%281%29/builds/4667 https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%20%281%29/builds/4012 Original issue's description: > Update component updater URLs. > > BUG=685897 > > Review-Url: https://codereview.chromium.org/2654033009 > Cr-Commit-Position: refs/heads/master@{#447564} > Committed: https://chromium.googlesource.com/chromium/src/+/9fefd20253ceb6af4fc3604ca29fcafc4c8454cd TBR=sorin@chromium.org,rkaplow@chromium.org,pastarmovj@chromium.org,waffles@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=685897 Review-Url: https://codereview.chromium.org/2675903002 Cr-Commit-Position: refs/heads/master@{#447940} Committed: https://chromium.googlesource.com/chromium/src/+/af271de2bcbaaec00b9b2d68f41fd0c0903f5e05

Patch Set 1 #

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -48 lines)			Patch
M	chrome/browser/policy/policy_browsertest.cc	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	components/component_updater/component_updater_url_constants.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	components/component_updater/component_updater_url_constants.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	components/component_updater/configurator_impl.cc	View	3 chunks	+2 lines, -12 lines	0 comments	Download
M	testing/variations/fieldtrial_testing_config.json	View	1 chunk	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 9 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675903002/1

3 years, 10 months ago (2017-02-03 03:46:10 UTC) #3

Sorin Jianu

Hi, I wonder what the process was to conclude this change had a performance problem ...

3 years, 10 months ago (2017-02-03 04:39:16 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/af271de2bcbaaec00b9b2d68f41fd0c0903f5e05

3 years, 10 months ago (2017-02-03 04:49:27 UTC) #7

dtu

On 2017/02/03 04:39:16, Sorin Jianu wrote: > Hi, I wonder what the process was to ...

3 years, 10 months ago (2017-02-03 05:24:45 UTC) #8

pkotwicz

3 years, 10 months ago (2017-02-03 20:24:43 UTC) #9

Message was sent while issue was closed.

I believe that the perf tests started failing because of http://crbug.com/688230
Your CL put us over the arbirtary limit for the size of command lines on
Android. I have posted https://codereview.chromium.org/2675713004/ to fix this

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages