Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2654033009:
Update component updater URLs. (Closed)
DescriptionUpdate component updater URLs.
BUG=685897
Review-Url: https://codereview.chromium.org/2654033009
Cr-Original-Commit-Position: refs/heads/master@{#447564}
Committed: https://chromium.googlesource.com/chromium/src/+/9fefd20253ceb6af4fc3604ca29fcafc4c8454cd
Review-Url: https://codereview.chromium.org/2654033009
Cr-Commit-Position: refs/heads/master@{#448490}
Committed: https://chromium.googlesource.com/chromium/src/+/a4f53d4741c9c426dc42809d7b1e11a78f5789f8
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix browser test. #Patch Set 3 : git pull #
Messages
Total messages: 40 (23 generated)
waffles@chromium.org changed reviewers: + rkaplow@chromium.org, sorin@chromium.org
PTAL! Plan is to use existing UMA metrics in combination with Omaha data to analyze the transition.
lgtm Thank you!
lgtm https://codereview.chromium.org/2654033009/diff/1/components/component_update... File components/component_updater/component_updater_url_constants.cc (right): https://codereview.chromium.org/2654033009/diff/1/components/component_update... components/component_updater/component_updater_url_constants.cc:21: const char kUpdaterDefaultUrlAlt[] = nit, I'd call it it AltUrl so it ends with Url but maybe that's just me
https://codereview.chromium.org/2654033009/diff/1/components/component_update... File components/component_updater/component_updater_url_constants.cc (right): https://codereview.chromium.org/2654033009/diff/1/components/component_update... components/component_updater/component_updater_url_constants.cc:21: const char kUpdaterDefaultUrlAlt[] = On 2017/01/27 17:28:38, rkaplow wrote: > nit, I'd call it it AltUrl so it ends with Url but maybe that's just me I see the point but I have a preference to just add a suffix; makes it easier to search. Let me know if you feel strongly.
The CQ bit was checked by waffles@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm yeah i getcha. Nope, don't feel strongly!
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by waffles@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
waffles@chromium.org changed reviewers: + pastarmovj@chromium.org
Now passing browser tests. +pastarmovj to review. Constructing a second configurator is a bit of a hack, but it seemed less evil than storing the true configurator somewhere global just for the purpose of running this test.
The CQ bit was checked by waffles@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by waffles@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sorin@chromium.org, rkaplow@chromium.org Link to the patchset: https://codereview.chromium.org/2654033009/#ps20001 (title: "Fix browser test.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485971715103470,
"parent_rev": "c5e6cf268178c579c2fe785de30dfd685118afff", "commit_rev":
"9fefd20253ceb6af4fc3604ca29fcafc4c8454cd"}
Message was sent while issue was closed.
Description was changed from ========== Update component updater URLs. BUG=685897 ========== to ========== Update component updater URLs. BUG=685897 Review-Url: https://codereview.chromium.org/2654033009 Cr-Commit-Position: refs/heads/master@{#447564} Committed: https://chromium.googlesource.com/chromium/src/+/9fefd20253ceb6af4fc3604ca29f... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/9fefd20253ceb6af4fc3604ca29f...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2675903002/ by dtu@chromium.org. The reason for reverting is: Lots of perf benchmarks started failing on Android. Bisect pointed to this change. https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus5X%20Perf%... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus6%20Perf%2... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus7v2%20Perf... https://build.chromium.org/p/chromium.perf/builders/Android%20Nexus9%20Perf%2....
Message was sent while issue was closed.
Description was changed from ========== Update component updater URLs. BUG=685897 Review-Url: https://codereview.chromium.org/2654033009 Cr-Commit-Position: refs/heads/master@{#447564} Committed: https://chromium.googlesource.com/chromium/src/+/9fefd20253ceb6af4fc3604ca29f... ========== to ========== Update component updater URLs. BUG=685897 Review-Url: https://codereview.chromium.org/2654033009 Cr-Commit-Position: refs/heads/master@{#447564} Committed: https://chromium.googlesource.com/chromium/src/+/9fefd20253ceb6af4fc3604ca29f... ==========
Trying again after #448429 increases command line size.
The CQ bit was checked by waffles@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by waffles@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sorin@chromium.org, pastarmovj@chromium.org, rkaplow@chromium.org Link to the patchset: https://codereview.chromium.org/2654033009/#ps40001 (title: "git pull")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486426851470890,
"parent_rev": "8c4f1ebc60f9d9df27f2fd432fda49d58842e0c9", "commit_rev":
"a4f53d4741c9c426dc42809d7b1e11a78f5789f8"}
Message was sent while issue was closed.
Description was changed from ========== Update component updater URLs. BUG=685897 Review-Url: https://codereview.chromium.org/2654033009 Cr-Commit-Position: refs/heads/master@{#447564} Committed: https://chromium.googlesource.com/chromium/src/+/9fefd20253ceb6af4fc3604ca29f... ========== to ========== Update component updater URLs. BUG=685897 Review-Url: https://codereview.chromium.org/2654033009 Cr-Original-Commit-Position: refs/heads/master@{#447564} Committed: https://chromium.googlesource.com/chromium/src/+/9fefd20253ceb6af4fc3604ca29f... Review-Url: https://codereview.chromium.org/2654033009 Cr-Commit-Position: refs/heads/master@{#448490} Committed: https://chromium.googlesource.com/chromium/src/+/a4f53d4741c9c426dc42809d7b1e... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/a4f53d4741c9c426dc42809d7b1e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
