Remove some pre-md code from TrayPopupUtils and UserView.

Remove some pre-md code from TrayPopupUtils and UserView.

Consolidate some button configuration between tray label buttons and
tray image buttons (TrayPopupBorderlessButton and SystemMenuButton).

Note some of the label button border assets are still being used until
crbug.com/686261 is addressed.

BUG=686288
Review-Url: https://codereview.chromium.org/2675893002
Cr-Commit-Position: refs/heads/master@{#448687}
Committed: https://chromium.googlesource.com/chromium/src/+/184394b156baaeb9ea061711192b5a5cae697505

[Evan Stade, 2017-02-03 02:44:02]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 02:44:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2017-02-03 02:45:05]

estade@chromium.org changed reviewers:
+ bruthig@chromium.org, sky@chromium.org

[Evan Stade, 2017-02-03 02:45:05]

We aren't supposed to start landing these pre-md cleanups till early next week,
but there's no reason we can't be prepared with reviewed and ready-to-land CLs
:)

[commit-bot: I haz the power, 2017-02-03 03:33:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-03 03:33:50]

Dry run: This issue passed the CQ dry run.

[sky, 2017-02-03 16:57:02]

LGTM

[bruthig, 2017-02-06 17:42:50]

One clarifying Q, otherwise LGTM

https://codereview.chromium.org/2675893002/diff/1/ash/common/system/user/user...
File ash/common/system/user/user_view.cc (left):

https://codereview.chromium.org/2675893002/diff/1/ash/common/system/user/user...
ash/common/system/user/user_view.cc:497:
logout_button->SetAccessibleName(title);
Why are we dropping the accessible name, isn't it needed for ChromeVox?

[Evan Stade, 2017-02-06 18:15:50]

https://codereview.chromium.org/2675893002/diff/1/ash/common/system/user/user...
File ash/common/system/user/user_view.cc (left):

https://codereview.chromium.org/2675893002/diff/1/ash/common/system/user/user...
ash/common/system/user/user_view.cc:497:
logout_button->SetAccessibleName(title);
On 2017/02/06 17:42:50, bruthig wrote:
> Why are we dropping the accessible name, isn't it needed for ChromeVox?

this is already done for us in the base class:
https://cs.chromium.org/chromium/src/ui/views/controls/button/label_button.cc...

[bruthig, 2017-02-06 18:36:40]

slgtm

https://codereview.chromium.org/2675893002/diff/1/ash/common/system/user/user...
File ash/common/system/user/user_view.cc (left):

https://codereview.chromium.org/2675893002/diff/1/ash/common/system/user/user...
ash/common/system/user/user_view.cc:497:
logout_button->SetAccessibleName(title);
On 2017/02/06 18:15:50, Evan Stade wrote:
> On 2017/02/06 17:42:50, bruthig wrote:
> > Why are we dropping the accessible name, isn't it needed for ChromeVox?
> 
> this is already done for us in the base class:
>
https://cs.chromium.org/chromium/src/ui/views/controls/button/label_button.cc...

Gotcha, thx!

[Evan Stade, 2017-02-07 18:14:45]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2017-02-07 18:15:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 19:13:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486491285527650, "parent_rev":
"cfc62226b8b375088327fd872c621e90f36f4d7f", "commit_rev":
"184394b156baaeb9ea061711192b5a5cae697505"}

[commit-bot: I haz the power, 2017-02-07 19:14:30]

Description was changed from

==========
Remove some pre-md code from TrayPopupUtils and UserView.

Consolidate some button configuration between tray label buttons and
tray image buttons (TrayPopupBorderlessButton and SystemMenuButton).

Note some of the label button border assets are still being used until
crbug.com/686261 is addressed.

BUG=686288
==========

to

==========
Remove some pre-md code from TrayPopupUtils and UserView.

Consolidate some button configuration between tray label buttons and
tray image buttons (TrayPopupBorderlessButton and SystemMenuButton).

Note some of the label button border assets are still being used until
crbug.com/686261 is addressed.

BUG=686288

Review-Url: https://codereview.chromium.org/2675893002
Cr-Commit-Position: refs/heads/master@{#448687}
Committed:
https://chromium.googlesource.com/chromium/src/+/184394b156baaeb9ea061711192b...
==========

[commit-bot: I haz the power, 2017-02-07 19:14:32]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/184394b156baaeb9ea061711192b...