Remove some pre-md code from TrayPopupUtils and UserView.

ash/common/system/tray/tray_popup_utils.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/system/tray/tray_popup_utils.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "ash/common/ash_constants.h"
@@ skipping 94 matching lines @@
   tri_view->SetMaxSize(container,
                        gfx::Size(SizeRangeLayout::kAbsoluteMaxSize,
                                  GetTrayConstant(TRAY_POPUP_ITEM_MAX_HEIGHT)));
 }
 
 class BorderlessLabelButton : public views::LabelButton {
  public:
   BorderlessLabelButton(views::ButtonListener* listener,
                         const base::string16& text)
       : LabelButton(listener, text) {
-    if (MaterialDesignController::IsSystemTrayMenuMaterial()) {
-      SetInkDropMode(views::InkDropHostView::InkDropMode::ON);
-      set_has_ink_drop_action_on_click(true);
-      set_ink_drop_base_color(kTrayPopupInkDropBaseColor);
-      set_ink_drop_visible_opacity(kTrayPopupInkDropRippleOpacity);
-      const int kHorizontalPadding = 20;
-      SetBorder(views::CreateEmptyBorder(gfx::Insets(0, kHorizontalPadding)));
-      TrayPopupItemStyle style(TrayPopupItemStyle::FontStyle::BUTTON);
-      style.SetupLabel(label());
-      SetFocusPainter(TrayPopupUtils::CreateFocusPainter());
-    } else {
-      SetBorder(std::unique_ptr<views::Border>(new TrayPopupLabelButtonBorder));
-      SetFocusPainter(views::Painter::CreateSolidFocusPainter(
-          kFocusBorderColor, gfx::Insets(1, 1, 2, 2)));
-      set_animate_on_state_change(false);
-    }
+    const int kHorizontalPadding = 20;
+    SetBorder(views::CreateEmptyBorder(gfx::Insets(0, kHorizontalPadding)));
+    TrayPopupItemStyle style(TrayPopupItemStyle::FontStyle::BUTTON);
+    style.SetupLabel(label());
     SetHorizontalAlignment(gfx::ALIGN_CENTER);
-    SetFocusForPlatform();
+    SetFocusPainter(TrayPopupUtils::CreateFocusPainter());
+
+    TrayPopupUtils::ConfigureTrayPopupButton(this);
   }
 
   ~BorderlessLabelButton() override {}
 
   // views::LabelButton:
-  int GetHeightForWidth(int width) const override {
-    if (MaterialDesignController::IsSystemTrayMenuMaterial())
-      return kMenuButtonSize;
-
-    return LabelButton::GetHeightForWidth(width);
-  }
+  int GetHeightForWidth(int width) const override { return kMenuButtonSize; }
 
  private:
+  // TODO(estade,bruthig): there's a lot in common here with ActionableView.
+  // Find a way to share. See related TODO on InkDropHostView::SetInkDropMode().
   std::unique_ptr<views::InkDrop> CreateInkDrop() override {
     return TrayPopupUtils::CreateInkDrop(TrayPopupInkDropStyle::INSET_BOUNDS,
                                          this);
   }
 
   std::unique_ptr<views::InkDropRipple> CreateInkDropRipple() const override {
     return TrayPopupUtils::CreateInkDropRipple(
         TrayPopupInkDropStyle::INSET_BOUNDS, this,
         GetInkDropCenterBasedOnLastEvent());
   }
@@ skipping 117 matching lines @@
   toggle->SetFocusPainter(CreateFocusPainter());
   toggle->SetAccessibleName(l10n_util::GetStringUTF16(accessible_name_id));
   return toggle;
 }
 
 std::unique_ptr<views::Painter> TrayPopupUtils::CreateFocusPainter() {
   return views::Painter::CreateSolidFocusPainter(
       kFocusBorderColor, kFocusBorderThickness, gfx::InsetsF());
 }
 
+void TrayPopupUtils::ConfigureTrayPopupButton(views::CustomButton* button) {
+  // All buttons that call into here want this focus painter, but
+  // SetFocusPainter is defined separately on derived classes and isn't part of
+  // CustomButton. TODO(estade): Address this.
+  // button->SetFocusPainter(TrayPopupUtils::CreateFocusPainter());
+  button->SetFocusForPlatform();
+
+  button->SetInkDropMode(views::InkDropHostView::InkDropMode::ON);
+  button->set_has_ink_drop_action_on_click(true);
+  button->set_ink_drop_base_color(kTrayPopupInkDropBaseColor);
+  button->set_ink_drop_visible_opacity(kTrayPopupInkDropRippleOpacity);
+}
+
 void TrayPopupUtils::ConfigureAsStickyHeader(views::View* view) {
   view->set_id(VIEW_ID_STICKY_HEADER);
   view->set_background(
       views::Background::CreateSolidBackground(kBackgroundColor));
   view->SetBorder(
       views::CreateEmptyBorder(gfx::Insets(kMenuSeparatorVerticalPadding, 0)));
   view->SetPaintToLayer();
   view->layer()->SetFillsBoundsOpaquely(false);
 }
 
@@ skipping 20 matching lines @@
 
 views::LabelButton* TrayPopupUtils::CreateTrayPopupBorderlessButton(
     views::ButtonListener* listener,
     const base::string16& text) {
   return new BorderlessLabelButton(listener, text);
 }
 
 views::LabelButton* TrayPopupUtils::CreateTrayPopupButton(
     views::ButtonListener* listener,
     const base::string16& text) {
-  if (!MaterialDesignController::IsSystemTrayMenuMaterial())
-    return CreateTrayPopupBorderlessButton(listener, text);
-
   auto* button = views::MdTextButton::Create(listener, text);
   button->SetProminent(true);
   return button;
 }
 
 views::Separator* TrayPopupUtils::CreateVerticalSeparator() {
   views::Separator* separator =
       new views::Separator(views::Separator::HORIZONTAL);
   separator->SetPreferredSize(kHorizontalSeparatorHeight);
   separator->SetColor(kHorizontalSeparatorColor);
@@ skipping 112 matching lines @@
 bool TrayPopupUtils::CanOpenWebUISettings(LoginStatus status) {
   // TODO(tdanderson): Consider moving this into WmShell, or introduce a
   // CanShowSettings() method in each delegate type that has a
   // ShowSettings() method.
   return status != LoginStatus::NOT_LOGGED_IN &&
          status != LoginStatus::LOCKED &&
          !WmShell::Get()->GetSessionStateDelegate()->IsInSecondaryLoginScreen();
 }
 
 }  // namespace ash