Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2675793005: Track constant InputDeviceCapabilities objects per-window. (Closed)

Created:
3 years, 10 months ago by sof
Modified:
3 years, 10 months ago
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, dtapuska+blinkwatch_chromium.org, Navid Zolghadr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Track constant InputDeviceCapabilities objects per-window. Do not keep global main thread Persistent<>s for the two constant InputDeviceCapabilities objects, as that will end up sharing wrapper objects across contexts. R=dcheng BUG=688569 Review-Url: https://codereview.chromium.org/2675793005 Cr-Commit-Position: refs/heads/master@{#448597} Committed: https://chromium.googlesource.com/chromium/src/+/3867c9867bbb9bbe1d1d4c2c68b60073cb45caaf

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : also test roundtripping within a Window context #

Total comments: 8

Patch Set 4 : switch to testharness #

Total comments: 2

Patch Set 5 : test tidying #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -58 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/security/cross-frame-mouse-source-capabilities.html View 1 2 3 4 1 chunk +46 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/resources/cross-frame-mouse-source-capabilities.html View 1 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/events/CompositionEvent.cpp View 2 chunks +11 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/events/KeyboardEvent.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/MouseEvent.cpp View 3 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/events/TouchEvent.cpp View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/UIEvent.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/events/UIEvent.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.h View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 4 chunks +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/input/GestureManager.cpp View 3 chunks +14 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/input/InputDeviceCapabilities.h View 2 chunks +24 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/input/InputDeviceCapabilities.cpp View 1 chunk +10 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/input/KeyboardEventManager.cpp View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 48 (24 generated)
sof
please take a look. The changes would be backportable without too much trouble, but I ...
3 years, 10 months ago (2017-02-04 15:57:47 UTC) #4
esprehn
What does the spec say for the lifetime of this object? Ex. Is it bound ...
3 years, 10 months ago (2017-02-04 17:44:36 UTC) #8
sof
On 2017/02/04 17:44:36, esprehn wrote: > What does the spec say for the lifetime of ...
3 years, 10 months ago (2017-02-04 18:08:13 UTC) #9
jochen (gone - plz use gerrit)
can you add a layout test?
3 years, 10 months ago (2017-02-04 18:12:45 UTC) #10
sof
rbyers@, lanwei@: could you clarify the required lifetime of InputDeviceCapabilities (see #9) ?
3 years, 10 months ago (2017-02-04 20:56:22 UTC) #12
sof
On 2017/02/04 18:12:45, jochen (travelling til Feb 4) wrote: > can you add a layout ...
3 years, 10 months ago (2017-02-04 20:56:45 UTC) #13
jochen (gone - plz use gerrit)
(waiting for somebody to clarify the lifetime requirements)
3 years, 10 months ago (2017-02-06 09:37:46 UTC) #18
sof
On 2017/02/06 09:37:46, jochen wrote: > (waiting for somebody to clarify the lifetime requirements) The ...
3 years, 10 months ago (2017-02-06 11:00:32 UTC) #21
lanwei
On 2017/02/06 11:00:32, sof wrote: > On 2017/02/06 09:37:46, jochen wrote: > > (waiting for ...
3 years, 10 months ago (2017-02-06 19:09:11 UTC) #24
sof
On 2017/02/06 19:09:11, lanwei wrote: > On 2017/02/06 11:00:32, sof wrote: > > On 2017/02/06 ...
3 years, 10 months ago (2017-02-06 19:15:13 UTC) #25
Rick Byers
On 2017/02/06 19:15:13, sof wrote: > On 2017/02/06 19:09:11, lanwei wrote: > > On 2017/02/06 ...
3 years, 10 months ago (2017-02-06 20:27:05 UTC) #26
sof
On 2017/02/06 20:27:05, Rick Byers wrote: > On 2017/02/06 19:15:13, sof wrote: > > On ...
3 years, 10 months ago (2017-02-06 21:35:06 UTC) #27
sof
Given the above, I suggest we move forwards with what's here.
3 years, 10 months ago (2017-02-07 06:45:00 UTC) #28
dcheng
https://codereview.chromium.org/2675793005/diff/40001/third_party/WebKit/LayoutTests/http/tests/security/cross-frame-mouse-source-capabilities.html File third_party/WebKit/LayoutTests/http/tests/security/cross-frame-mouse-source-capabilities.html (right): https://codereview.chromium.org/2675793005/diff/40001/third_party/WebKit/LayoutTests/http/tests/security/cross-frame-mouse-source-capabilities.html#newcode8 third_party/WebKit/LayoutTests/http/tests/security/cross-frame-mouse-source-capabilities.html:8: window.jsTestIsAsync = true; Nit: can we write this using ...
3 years, 10 months ago (2017-02-07 06:53:04 UTC) #29
sof
https://codereview.chromium.org/2675793005/diff/40001/third_party/WebKit/Source/core/events/CompositionEvent.cpp File third_party/WebKit/Source/core/events/CompositionEvent.cpp (right): https://codereview.chromium.org/2675793005/diff/40001/third_party/WebKit/Source/core/events/CompositionEvent.cpp#newcode45 third_party/WebKit/Source/core/events/CompositionEvent.cpp:45: view ? view->getInputDeviceCapabilities()->firesTouchEvents(false) On 2017/02/07 06:53:04, dcheng wrote: > ...
3 years, 10 months ago (2017-02-07 07:08:58 UTC) #30
dcheng
https://codereview.chromium.org/2675793005/diff/40001/third_party/WebKit/Source/core/events/CompositionEvent.cpp File third_party/WebKit/Source/core/events/CompositionEvent.cpp (right): https://codereview.chromium.org/2675793005/diff/40001/third_party/WebKit/Source/core/events/CompositionEvent.cpp#newcode45 third_party/WebKit/Source/core/events/CompositionEvent.cpp:45: view ? view->getInputDeviceCapabilities()->firesTouchEvents(false) On 2017/02/07 07:08:58, sof wrote: > ...
3 years, 10 months ago (2017-02-07 07:20:21 UTC) #31
sof
https://codereview.chromium.org/2675793005/diff/40001/third_party/WebKit/Source/core/events/CompositionEvent.cpp File third_party/WebKit/Source/core/events/CompositionEvent.cpp (right): https://codereview.chromium.org/2675793005/diff/40001/third_party/WebKit/Source/core/events/CompositionEvent.cpp#newcode45 third_party/WebKit/Source/core/events/CompositionEvent.cpp:45: view ? view->getInputDeviceCapabilities()->firesTouchEvents(false) On 2017/02/07 07:20:21, dcheng wrote: > ...
3 years, 10 months ago (2017-02-07 07:38:15 UTC) #32
sof
https://codereview.chromium.org/2675793005/diff/40001/third_party/WebKit/Source/core/events/UIEvent.cpp File third_party/WebKit/Source/core/events/UIEvent.cpp (right): https://codereview.chromium.org/2675793005/diff/40001/third_party/WebKit/Source/core/events/UIEvent.cpp#newcode61 third_party/WebKit/Source/core/events/UIEvent.cpp:61: initUIEventInternal(typeArg, canBubbleArg, cancelableArg, nullptr, viewArg, Ah, all init*Event() get ...
3 years, 10 months ago (2017-02-07 07:41:45 UTC) #33
sof
https://codereview.chromium.org/2675793005/diff/40001/third_party/WebKit/LayoutTests/http/tests/security/cross-frame-mouse-source-capabilities.html File third_party/WebKit/LayoutTests/http/tests/security/cross-frame-mouse-source-capabilities.html (right): https://codereview.chromium.org/2675793005/diff/40001/third_party/WebKit/LayoutTests/http/tests/security/cross-frame-mouse-source-capabilities.html#newcode8 third_party/WebKit/LayoutTests/http/tests/security/cross-frame-mouse-source-capabilities.html:8: window.jsTestIsAsync = true; On 2017/02/07 06:53:04, dcheng wrote: > ...
3 years, 10 months ago (2017-02-07 08:58:05 UTC) #34
dcheng
> Given https://codereview.chromium.org/2675793005/#msg33 , this issue has been > addressed? This CL LGTM. The part ...
3 years, 10 months ago (2017-02-07 09:14:40 UTC) #35
sof
On 2017/02/07 09:14:40, dcheng wrote: > > Given https://codereview.chromium.org/2675793005/#msg33 , this issue has been > ...
3 years, 10 months ago (2017-02-07 09:25:50 UTC) #36
sof
https://codereview.chromium.org/2675793005/diff/60001/third_party/WebKit/LayoutTests/http/tests/security/cross-frame-mouse-source-capabilities.html File third_party/WebKit/LayoutTests/http/tests/security/cross-frame-mouse-source-capabilities.html (right): https://codereview.chromium.org/2675793005/diff/60001/third_party/WebKit/LayoutTests/http/tests/security/cross-frame-mouse-source-capabilities.html#newcode27 third_party/WebKit/LayoutTests/http/tests/security/cross-frame-mouse-source-capabilities.html:27: assert_true(evt.data === undefined); On 2017/02/07 09:14:40, dcheng wrote: > ...
3 years, 10 months ago (2017-02-07 09:29:57 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675793005/80001
3 years, 10 months ago (2017-02-07 11:07:43 UTC) #45
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 11:12:37 UTC) #48
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3867c9867bbb9bbe1d1d4c2c68b6...

Powered by Google App Engine
This is Rietveld 408576698