Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: third_party/WebKit/Source/core/input/InputDeviceCapabilities.h

Issue 2675793005: Track constant InputDeviceCapabilities objects per-window. (Closed)
Patch Set: test tidying Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/InputDeviceCapabilities.h
diff --git a/third_party/WebKit/Source/core/input/InputDeviceCapabilities.h b/third_party/WebKit/Source/core/input/InputDeviceCapabilities.h
index f869a697c49d3d4d09a02a8236db6eb400275408..d8731f3e86d0cc2fe91c3b074b8e74b5f7338689 100644
--- a/third_party/WebKit/Source/core/input/InputDeviceCapabilities.h
+++ b/third_party/WebKit/Source/core/input/InputDeviceCapabilities.h
@@ -17,14 +17,6 @@ class CORE_EXPORT InputDeviceCapabilities final
DEFINE_WRAPPERTYPEINFO();
public:
- // This return a static local InputDeviceCapabilities pointer which has
- // firesTouchEvents set to be true.
- static InputDeviceCapabilities* firesTouchEventsSourceCapabilities();
-
- // This return a static local InputDeviceCapabilities pointer which has
- // firesTouchEvents set to be false.
- static InputDeviceCapabilities* doesntFireTouchEventsSourceCapabilities();
-
static InputDeviceCapabilities* create(bool firesTouchEvents) {
return new InputDeviceCapabilities(firesTouchEvents);
}
@@ -48,6 +40,30 @@ class CORE_EXPORT InputDeviceCapabilities final
bool m_firesTouchEvents;
};
+// Grouping constant-valued InputDeviceCapabilities objects together,
+// which is kept and used by each 'view' (DOMWindow) that dispatches
+// events parameterized over InputDeviceCapabilities.
+//
+// TODO(sof): lazily instantiate InputDeviceCapabilities instances upon
+// UIEvent access instead. This would allow internal tracking of such
+// capabilities by value.
+class InputDeviceCapabilitiesConstants final
+ : public GarbageCollected<InputDeviceCapabilitiesConstants> {
+ public:
+ // Returns an InputDeviceCapabilities which has
+ // |firesTouchEvents| set to value of |firesTouch|.
+ InputDeviceCapabilities* firesTouchEvents(bool firesTouch);
+
+ DEFINE_INLINE_TRACE() {
+ visitor->trace(m_firesTouchEvents);
+ visitor->trace(m_doesntFireTouchEvents);
+ }
+
+ private:
+ Member<InputDeviceCapabilities> m_firesTouchEvents;
+ Member<InputDeviceCapabilities> m_doesntFireTouchEvents;
+};
+
} // namespace blink
#endif // InputDeviceCapabilities_h

Powered by Google App Engine
This is Rietveld 408576698