Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2675763006: Fix paint invalidation issue on exiting printing (Closed)

Created:
3 years, 10 months ago by Xianzhu
Modified:
3 years, 10 months ago
Reviewers:
pdr.
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix paint invalidation issue on exiting printing This was caused by https://codereview.chromium.org/2583733003. I forgot to remove the !slimmingPaintInvalidationEnabled() condition. I failed to create an automatic test. Even the manual test can't reproduce the bug if printing is started by script 'print()'. BUG=687848 Review-Url: https://codereview.chromium.org/2675763006 Cr-Commit-Position: refs/heads/master@{#448183} Committed: https://chromium.googlesource.com/chromium/src/+/604a36b20d9ffe65380031f3f708d859d81f71be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
A third_party/WebKit/ManualTests/print-iframe-containing-fixed.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
Xianzhu
3 years, 10 months ago (2017-02-03 23:32:52 UTC) #2
pdr.
On 2017/02/03 at 23:32:52, wangxianzhu wrote: > LGTM
3 years, 10 months ago (2017-02-04 00:06:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675763006/1
3 years, 10 months ago (2017-02-04 00:57:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-04 05:35:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675763006/1
3 years, 10 months ago (2017-02-04 06:15:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on ...
3 years, 10 months ago (2017-02-04 08:16:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675763006/1
3 years, 10 months ago (2017-02-04 17:12:33 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) win_chromium_rel_ng on ...
3 years, 10 months ago (2017-02-04 19:13:07 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675763006/1
3 years, 10 months ago (2017-02-05 02:04:07 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-05 10:03:33 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/604a36b20d9ffe65380031f3f708...

Powered by Google App Engine
This is Rietveld 408576698