Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2583733003: Use LayoutObject::subtreeNeedsPaintPropertyUpdate for printing invalidation (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
pdr.
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use LayoutObject::subtreeNeedsPaintPropertyUpdate for printing invalidation This changes the https://codereview.chromium.org/2575653002/ method to using https://codereview.chromium.org/2585603002/ to achieve the same goal: updating all paint properties before/after printing. BUG=645667 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/51ae241c5504c2f9ec1fbb5e8e8039b1f2ad07d1 Cr-Commit-Position: refs/heads/master@{#440507}

Patch Set 1 #

Patch Set 2 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -32 lines) Patch
M third_party/WebKit/Source/core/frame/FrameView.h View 1 2 chunks +3 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.h View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Xianzhu
4 years ago (2016-12-22 18:37:24 UTC) #5
pdr.
On 2016/12/22 at 18:37:24, wangxianzhu wrote: > LGTM
4 years ago (2016-12-22 21:14:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2583733003/20001
4 years ago (2016-12-22 21:23:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-22 21:28:33 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-22 21:34:43 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/51ae241c5504c2f9ec1fbb5e8e8039b1f2ad07d1
Cr-Commit-Position: refs/heads/master@{#440507}

Powered by Google App Engine
This is Rietveld 408576698