Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
Review-Url: https://codereview.chromium.org/2675763005
Cr-Commit-Position: refs/heads/master@{#449394}
Committed: https://chromium.googlesource.com/chromium/src/+/bb5dd0aa7d2d6c0c2c9a5dbd6efbefcf1d6f70e9

[zakerinasab, 2017-02-03 17:24:59]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The
expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The
expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

[zakerinasab, 2017-02-03 17:24:59]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[zakerinasab, 2017-02-03 17:25:11]

CL uploaded. PTAL.

[Justin Novosad, 2017-02-08 18:23:33]

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-clip-rule.html (right):

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-clip-rule.html:28: function
prepareTestScenario() {
Nit: unnecessary nested function

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-context-gc-custom-properties.html
(right):

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-context-gc-custom-properties.html:21:
test(function(t) {
Are you sure this works as expected? I am concerned that the test may exit
before the asserts are reached. I think the proper design is something like this

function runTest() {
  canvas = document.createElement("canvas");
  (...)
  assert_equals(...);
}

async_test( t => {
  window.onload = function() {
    t.step(runTest);
    t.done();
  }
}

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-createPattern-fillRect-shadow.html
(right):

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-createPattern-fillRect-shadow.html:53:
test(function(t) {
The test hraness may terminate before this is reached. This needs to be written
as an async test.

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-createPattern-fillRect-shadow.html:146:
window.jsTestIsAsync = true;
This is no longer relevant.

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-currentTransform.html
(right):

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-currentTransform.html:230:
setCurrentTransformToNonfinite(ctx, Infinity, 0, 0, 0, 0, 0);
this would be a really good place to use generate_tests.

[zakerinasab, 2017-02-08 19:57:50]

Comments addressed. PTAL.

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-clip-rule.html (right):

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-clip-rule.html:28: function
prepareTestScenario() {
On 2017/02/08 18:23:33, Justin Novosad wrote:
> Nit: unnecessary nested function

Done.

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-context-gc-custom-properties.html
(right):

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-context-gc-custom-properties.html:21:
test(function(t) {
On 2017/02/08 18:23:33, Justin Novosad wrote:
> Are you sure this works as expected? I am concerned that the test may exit
> before the asserts are reached. I think the proper design is something like
this
> 
> function runTest() {
>   canvas = document.createElement("canvas");
>   (...)
>   assert_equals(...);
> }
> 
> async_test( t => {
>   window.onload = function() {
>     t.step(runTest);
>     t.done();
>   }
> }

Done.

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/fast/canvas/canvas-createPattern-fillRect-shadow.html
(right):

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-createPattern-fillRect-shadow.html:53:
test(function(t) {
On 2017/02/08 18:23:33, Justin Novosad wrote:
> The test hraness may terminate before this is reached. This needs to be
written
> as an async test.

Done.

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-createPattern-fillRect-shadow.html:146:
window.jsTestIsAsync = true;
On 2017/02/08 18:23:33, Justin Novosad wrote:
> This is no longer relevant.

Done.

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-currentTransform.html
(right):

https://codereview.chromium.org/2675763005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-currentTransform.html:230:
setCurrentTransformToNonfinite(ctx, Infinity, 0, 0, 0, 0, 0);
On 2017/02/08 18:23:33, Justin Novosad wrote:
> this would be a really good place to use generate_tests.

Done.

[Justin Novosad, 2017-02-08 20:19:29]

https://codereview.chromium.org/2675763005/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-currentTransform.html
(right):

https://codereview.chromium.org/2675763005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-currentTransform.html:233:
['', [ctx, Infinity, 0, 0, 0, 0, 0]],
The scenarios should have names so that a reported failure can be traced back to
to a specific case in the code.  Does not need to be anything fancy. Ex: 'case
1', 'case 2' etc.

[zakerinasab, 2017-02-09 15:39:50]

Comments addressed. PTAL.

https://codereview.chromium.org/2675763005/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-currentTransform.html
(right):

https://codereview.chromium.org/2675763005/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-currentTransform.html:233:
['', [ctx, Infinity, 0, 0, 0, 0, 0]],
On 2017/02/08 20:19:29, Justin Novosad wrote:
> The scenarios should have names so that a reported failure can be traced back
to
> to a specific case in the code.  Does not need to be anything fancy. Ex: 'case
> 1', 'case 2' etc.

Done.

[Justin Novosad, 2017-02-09 19:48:42]

lgtm

[zakerinasab, 2017-02-09 19:49:11]

The CQ bit was checked by zakerinasab@chromium.org

[commit-bot: I haz the power, 2017-02-09 19:49:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 20:28:02]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486669751252790,
"parent_rev": "c140e50e0f1628e23737fd530e5d280b6335dea3", "commit_rev":
"bb5dd0aa7d2d6c0c2c9a5dbd6efbefcf1d6f70e9"}

[commit-bot: I haz the power, 2017-02-09 20:28:32]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The
expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The
expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2675763005
Cr-Commit-Position: refs/heads/master@{#449394}
Committed:
https://chromium.googlesource.com/chromium/src/+/bb5dd0aa7d2d6c0c2c9a5dbd6efb...
==========

[commit-bot: I haz the power, 2017-02-09 20:28:33]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bb5dd0aa7d2d6c0c2c9a5dbd6efb...