third_party/WebKit/LayoutTests/fast/canvas/canvas-context-gc-custom-properties.html - Issue 2675763005: Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/canvas/canvas-context-gc-custom-properties.html

Issue 2675763005: Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests. (Closed)

Patch Set: Corrections Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/canvas/canvas-clip-rule.html ('K') | « third_party/WebKit/LayoutTests/fast/canvas/canvas-context-attributes-default-value-expected.txt ('k') | third_party/WebKit/LayoutTests/fast/canvas/canvas-context-gc-custom-properties-expected.txt » ('j') | third_party/WebKit/LayoutTests/fast/canvas/canvas-createPattern-fillRect-shadow.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <script src="../../resources/testharness.js"></script>

2 <head>	2 <script src="../../resources/testharnessreport.js"></script>

3 <script src="../../resources/js-test.js"></script>

4 </head>

5 <body>

6 <script>	3 <script>

7 description("Verify that the custom properties on a Canvas 2D rendering context object are retained across GCs.");	4 function gc() {

8	5 if (typeof GCController !== "undefined")

9 window.jsTestIsAsync = true;	6 GCController.collectAll();

10	7 else {

11 if (window.testRunner) {	8 var gcRec = function (n) {

12 testRunner.dumpAsText();	9 if (n < 1)

13 testRunner.waitUntilDone();	10 return {};

	11 var temp = {i: "ab" + i + (i / 100000)};

	12 temp += "foo";

	13 gcRec(n-1);

	14 };

	15 for (var i = 0; i < 1000; i++)

	16 gcRec(10);

	17 }

14 }	18 }

15	19

16 function runTest() {	20 function runTest() {

17 canvas = document.createElement("canvas");	21 test(function(t) {
	Justin Novosad 2017/02/08 18:23:33 Are you sure this works as expected? I am concerne Are you sure this works as expected? I am concerned that the test may exit before the asserts are reached. I think the proper design is something like this function runTest() { canvas = document.createElement("canvas"); (...) assert_equals(...); } async_test( t => { window.onload = function() { t.step(runTest); t.done(); } } zakerinasab 2017/02/08 19:57:49 Done. Show quoted text On 2017/02/08 18:23:33, Justin Novosad wrote: > Are you sure this works as expected? I am concerned that the test may exit > before the asserts are reached. I think the proper design is something like this > > function runTest() { > canvas = document.createElement("canvas"); > (...) > assert_equals(...); > } > > async_test( t => { > window.onload = function() { > t.step(runTest); > t.done(); > } > } Done.
18 context = canvas.getContext("2d");	22 canvas = document.createElement("canvas");

19 context.customProperty = "value";	23 context = canvas.getContext("2d");

20 shouldBeEqualToString("context.customProperty", "value");	24 context.customProperty = "value";

21 context = null;	25 assert_equals(context.customProperty, "value");

22 gc();	26 context = null;

23 context = canvas.getContext("2d");	27 gc();

24 shouldBeEqualToString("context.customProperty", "value");	28 context = canvas.getContext("2d");

25 finishJSTest();	29 assert_equals(context.customProperty, "value");

	30 }, 'Verify that the custom properties on a Canvas 2D rendering context objec t are retained across GCs.');

26 }	31 }

27	32

28 window.onload = runTest;	33 window.onload = runTest;

29 </script>	34 </script>

30 </body>

31 </html>

OLD	NEW