Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2675723004: 🏠Restore interactivity when context menu closes (Closed)

Created:
3 years, 10 months ago by dgn
Modified:
3 years, 10 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Restore interactivity when context menu closes Makes the context menu manager from the bottom sheet listen to context menu close events from the parent ChromeActivity BUG=688391 Review-Url: https://codereview.chromium.org/2675723004 Cr-Commit-Position: refs/heads/master@{#448003} Committed: https://chromium.googlesource.com/chromium/src/+/10396fdbdb04e11781710dc62fccaa69266e3f10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java View 3 chunks +10 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
dgn
PTAL. Added the same registration as we have in NewTabPageView
3 years, 10 months ago (2017-02-03 15:16:20 UTC) #2
Michael van Ouwerkerk
lgtm I think this could be caught by an instrumentation test. Do we have any ...
3 years, 10 months ago (2017-02-03 15:19:48 UTC) #6
dgn
On 2017/02/03 15:19:48, Michael van Ouwerkerk wrote: > lgtm I think this could be caught ...
3 years, 10 months ago (2017-02-03 15:26:22 UTC) #7
Bernhard Bauer
lgtm
3 years, 10 months ago (2017-02-03 15:32:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675723004/1
3 years, 10 months ago (2017-02-03 16:08:43 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 16:40:21 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/10396fdbdb04e11781710dc62fcc...

Powered by Google App Engine
This is Rietveld 408576698