Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1693)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java

Issue 2675723004: 🏠Restore interactivity when context menu closes (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
index 64705be3321838b95a31c2cd36032ae992228a8b..8dd46dd761567430452e1486c6a80d391c7d619d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetContent.java
@@ -11,6 +11,7 @@
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeActivity;
import org.chromium.chrome.browser.ntp.ContextMenuManager;
+import org.chromium.chrome.browser.ntp.NewTabPage.DestructionObserver;
import org.chromium.chrome.browser.ntp.cards.NewTabPageAdapter;
import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;
import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge;
@@ -34,7 +35,7 @@
private final SnippetsBridge mSnippetsBridge;
public SuggestionsBottomSheetContent(
- ChromeActivity activity, Tab tab, TabModelSelector tabModelSelector) {
+ final ChromeActivity activity, Tab tab, TabModelSelector tabModelSelector) {
mRecyclerView = (NewTabPageRecyclerView) LayoutInflater.from(activity).inflate(
R.layout.new_tab_page_recycler_view, null, false);
@@ -47,7 +48,15 @@ public SuggestionsBottomSheetContent(
mSuggestionsManager = new SuggestionsUiDelegateImpl(
mSnippetsBridge, mSnippetsBridge, navigationDelegate, profile, tab);
+
mContextMenuManager = new ContextMenuManager(activity, navigationDelegate, mRecyclerView);
+ activity.getWindowAndroid().addContextMenuCloseListener(mContextMenuManager);
+ mSuggestionsManager.addDestructionObserver(new DestructionObserver() {
+ @Override
+ public void onDestroy() {
+ activity.getWindowAndroid().removeContextMenuCloseListener(mContextMenuManager);
+ }
+ });
NewTabPageAdapter adapter = new NewTabPageAdapter(mSuggestionsManager, null, uiConfig,
OfflinePageBridge.getForProfile(profile), mContextMenuManager);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698