Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2675613002: Rename ShouldUpdateHistoryResult enum values to not use NO. (Closed)

Created:
3 years, 10 months ago by Patti Lor
Modified:
3 years, 10 months ago
Reviewers:
asanka
CC:
asanka, chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ShouldUpdateHistoryResult enum values to not use NO. Avoid clashes with the NO keyword in Objective-C. BUG=687822 Review-Url: https://codereview.chromium.org/2675613002 Cr-Commit-Position: refs/heads/master@{#448194} Committed: https://chromium.googlesource.com/chromium/src/+/df7ed49e332e5ec80d670e6cc855722d8e368c7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/download/download_history.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Patti Lor
Hi asanka@, PTAL, just a rename. Thanks!
3 years, 10 months ago (2017-02-03 00:09:48 UTC) #6
asanka
lgtm
3 years, 10 months ago (2017-02-03 15:14:04 UTC) #7
Patti Lor
Thank you!
3 years, 10 months ago (2017-02-05 23:13:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675613002/1
3 years, 10 months ago (2017-02-05 23:13:55 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 00:35:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/df7ed49e332e5ec80d670e6cc855...

Powered by Google App Engine
This is Rietveld 408576698