Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: chrome/browser/download/download_history.cc

Issue 2675613002: Rename ShouldUpdateHistoryResult enum values to not use NO. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_history.cc
diff --git a/chrome/browser/download/download_history.cc b/chrome/browser/download/download_history.cc
index d86d720eb736ad1cc6d372b288f8c26bc7bd2a2d..e79dec2caeda511682db87b022712705cafe716c 100644
--- a/chrome/browser/download/download_history.cc
+++ b/chrome/browser/download/download_history.cc
@@ -144,9 +144,9 @@ history::DownloadRow GetDownloadRow(
}
enum class ShouldUpdateHistoryResult {
- NO,
- UPDATE,
- UPDATE_IMMEDIATELY,
+ NO_UPDATE,
+ UPDATE,
+ UPDATE_IMMEDIATELY,
};
ShouldUpdateHistoryResult ShouldUpdateHistory(
@@ -181,7 +181,7 @@ ShouldUpdateHistoryResult ShouldUpdateHistory(
return ShouldUpdateHistoryResult::UPDATE;
}
- return ShouldUpdateHistoryResult::NO;
+ return ShouldUpdateHistoryResult::NO_UPDATE;
}
typedef std::vector<history::DownloadRow> InfoVector;
@@ -430,7 +430,8 @@ void DownloadHistory::OnDownloadUpdated(
history::DownloadRow current_info(GetDownloadRow(item));
ShouldUpdateHistoryResult should_update_result =
ShouldUpdateHistory(data->info(), current_info);
- bool should_update = (should_update_result != ShouldUpdateHistoryResult::NO);
+ bool should_update =
+ (should_update_result != ShouldUpdateHistoryResult::NO_UPDATE);
UMA_HISTOGRAM_ENUMERATION("Download.HistoryPropagatedUpdate",
should_update, 2);
if (should_update) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698