Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2675593003: Enable running of fasta tests on build bot. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased on 17d8de6063e78eb14b7c1814626743164a4473d9. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -74 lines) Patch
M pkg/front_end/lib/src/fasta/run.dart View 1 chunk +4 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/testing/kernel_chain.dart View 1 3 chunks +50 lines, -55 lines 0 comments Download
M pkg/front_end/lib/src/fasta/testing/suite.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/test/fasta/testing.json View 1 chunk +6 lines, -1 line 0 comments Download
M pkg/pkg.status View 1 chunk +1 line, -1 line 0 comments Download
M pkg/testing/lib/src/chain.dart View 3 chunks +5 lines, -1 line 0 comments Download
M pkg/testing/lib/src/zone_helper.dart View 3 chunks +15 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (3 generated)
ahe
3 years, 10 months ago (2017-02-02 13:48:23 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-03 00:19:59 UTC) #4
ahe
3 years, 10 months ago (2017-02-03 06:12:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7512ab5c7996c3e422bb6ef0094b65a29819d3e5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698