Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: pkg/front_end/lib/src/fasta/run.dart

Issue 2675593003: Enable running of fasta tests on build bot. (Closed)
Patch Set: Rebased on 17d8de6063e78eb14b7c1814626743164a4473d9. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/testing/kernel_chain.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/run.dart
diff --git a/pkg/front_end/lib/src/fasta/run.dart b/pkg/front_end/lib/src/fasta/run.dart
index f181849a8b1d7fa12652bb5104f44df80be5202b..5543e91f8e174a545fd99cc06778b68bc8df9422 100644
--- a/pkg/front_end/lib/src/fasta/run.dart
+++ b/pkg/front_end/lib/src/fasta/run.dart
@@ -14,23 +14,15 @@ import 'package:testing/testing.dart' show
StdioProcess;
import 'testing/kernel_chain.dart' show
- TestContext;
+ computeDartVm,
+ computePatchedSdk;
import 'compiler_command_line.dart' show
CompilerCommandLine;
Future<int> run(Uri uri, CompilerCommandLine cl) async {
- Uri dartVm;
-
- Future<TestContext> constructor(
- suite, Map<String, String> environment, String sdk, Uri vm,
- Uri packages, bool strongMode, dartSdk, bool updateExpectations) {
- dartVm = vm;
- return null;
- }
- // TODO(ahe): Using [TestContext] to compute a value for [dartVm]. Make the
- // API simpler.
- await TestContext.create(null, <String, String>{}, constructor);
+ Uri sdk = await computePatchedSdk();
+ Uri dartVm = computeDartVm(sdk);
List<String> arguments = <String>["${uri.toFilePath()}"]
..addAll(cl.arguments.skip(1));
if (cl.verbose) {
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/testing/kernel_chain.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698