Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Unified Diff: pkg/testing/lib/src/chain.dart

Issue 2675593003: Enable running of fasta tests on build bot. (Closed)
Patch Set: Rebased on 17d8de6063e78eb14b7c1814626743164a4473d9. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/pkg.status ('k') | pkg/testing/lib/src/zone_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/testing/lib/src/chain.dart
diff --git a/pkg/testing/lib/src/chain.dart b/pkg/testing/lib/src/chain.dart
index 5a32f775e3d8de0a47e06453cac96ca35860ed19..a74462e82841a68ce227711c5888877c00719d4f 100644
--- a/pkg/testing/lib/src/chain.dart
+++ b/pkg/testing/lib/src/chain.dart
@@ -179,6 +179,10 @@ abstract class ChainContext {
isAsync = step.isAsync;
logStepStart(completed, unexpectedResults.length, descriptions.length,
suite, description, step);
+ // TODO(ahe): It's important to share the zone error reporting zone
+ // between all the tasks. Otherwise, if a future completes with an
+ // error in one zone, and gets stored, it becomes an uncaught error
+ // in other zones (this happened in createPlatform).
future = runGuarded(() async {
try {
return await step.run(input, this);
@@ -218,6 +222,7 @@ abstract class ChainContext {
unexpectedResults[description] = result;
unexpectedOutcomes[description] = expectedOutcomes;
logUnexpectedResult(suite, description, result, expectedOutcomes);
+ exitCode = 1;
} else {
logMessage(sb);
}
@@ -238,7 +243,6 @@ abstract class ChainContext {
logSuiteComplete();
if (unexpectedResults.isNotEmpty) {
unexpectedResults.forEach((TestDescription description, Result result) {
- exitCode = 1;
logUnexpectedResult(suite, description, result,
unexpectedOutcomes[description]);
});
« no previous file with comments | « pkg/pkg.status ('k') | pkg/testing/lib/src/zone_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698