[Extensions] Remove usage of extension_action_redesign in declarativeContent

[Extensions] Remove usage of extension_action_redesign in declarativeContent

Remove the usage of FeatureSwitch::extension_action_redesign in the
declarativeContent API. This was used to simulate an extension not
having a page action and us returning the proper error. These tests
are still somewhat valid (though certainly not as prevalent as they
were), so simulate an extension with no action by a) loading a
component extension and b) loading an extension with a browser action.

Clean up ShowPageActionWithoutPageActionTest api test by making it
parameterized.

BUG=590321
Review-Url: https://codereview.chromium.org/2675563002
Cr-Commit-Position: refs/heads/master@{#447929}
Committed: https://chromium.googlesource.com/chromium/src/+/e3f7c9aa8a772173128960a030bc35ce6de06420

[Devlin, 2017-02-02 01:15:40]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 01:16:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 01:58:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 01:58:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2017-02-02 20:50:05]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 20:50:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 21:34:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 21:34:16]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-02-03 00:40:18]

Description was changed from

==========
[Extensions] Remove usage of extension_action_redesign in declarativeContent

Remove the usage of FeatureSwitch::extension_action_redesign in the
declarativeContent API. This was used to simulate an extension not
having a page action and us returning the proper error. These tests
are still somewhat valid (though certainly not as prevalent as they
were), so simulate an extension with no action by loading a component
extension.

Clean up ShowPageActionWithoutPageActionTest api test by making it
parameterized.

Also fix a few small issues in ChromeTestExtensionLoader.

BUG=590321
==========

to

==========
[Extensions] Remove usage of extension_action_redesign in declarativeContent

Remove the usage of FeatureSwitch::extension_action_redesign in the
declarativeContent API. This was used to simulate an extension not
having a page action and us returning the proper error. These tests
are still somewhat valid (though certainly not as prevalent as they
were), so simulate an extension with no action by a) loading a
component extension and b) loading an extension with a browser action.

Clean up ShowPageActionWithoutPageActionTest api test by making it
parameterized.

BUG=590321
==========

[Devlin, 2017-02-03 00:41:22]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2017-02-03 00:57:21]

lgtm

[Devlin, 2017-02-03 01:00:19]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-02-03 01:01:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 04:24:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486083619782110,
"parent_rev": "a6ec659f2418eb03341c3f6e37632804d2b7499d", "commit_rev":
"e3f7c9aa8a772173128960a030bc35ce6de06420"}

[commit-bot: I haz the power, 2017-02-03 04:24:34]

Description was changed from

==========
[Extensions] Remove usage of extension_action_redesign in declarativeContent

Remove the usage of FeatureSwitch::extension_action_redesign in the
declarativeContent API. This was used to simulate an extension not
having a page action and us returning the proper error. These tests
are still somewhat valid (though certainly not as prevalent as they
were), so simulate an extension with no action by a) loading a
component extension and b) loading an extension with a browser action.

Clean up ShowPageActionWithoutPageActionTest api test by making it
parameterized.

BUG=590321
==========

to

==========
[Extensions] Remove usage of extension_action_redesign in declarativeContent

Remove the usage of FeatureSwitch::extension_action_redesign in the
declarativeContent API. This was used to simulate an extension not
having a page action and us returning the proper error. These tests
are still somewhat valid (though certainly not as prevalent as they
were), so simulate an extension with no action by a) loading a
component extension and b) loading an extension with a browser action.

Clean up ShowPageActionWithoutPageActionTest api test by making it
parameterized.

BUG=590321

Review-Url: https://codereview.chromium.org/2675563002
Cr-Commit-Position: refs/heads/master@{#447929}
Committed:
https://chromium.googlesource.com/chromium/src/+/e3f7c9aa8a772173128960a030bc...
==========

[commit-bot: I haz the power, 2017-02-03 04:24:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e3f7c9aa8a772173128960a030bc...