Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1425)

Unified Diff: chrome/browser/extensions/api/declarative_content/content_action_unittest.cc

Issue 2675563002: [Extensions] Remove usage of extension_action_redesign in declarativeContent (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc b/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
index 44454fedee6938a1d76cace20b1d3148fdade8ef..367269e2dea1130d6519cc6c272fc03576b7e6e3 100644
--- a/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
+++ b/chrome/browser/extensions/api/declarative_content/content_action_unittest.cc
@@ -11,6 +11,7 @@
#include "base/test/values_test_util.h"
#include "chrome/browser/extensions/extension_action.h"
#include "chrome/browser/extensions/extension_action_manager.h"
+#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_service_test_base.h"
#include "chrome/browser/extensions/extension_tab_util.h"
#include "chrome/browser/extensions/test_extension_environment.h"
@@ -21,7 +22,6 @@
#include "extensions/browser/extension_system.h"
#include "extensions/common/extension.h"
#include "extensions/common/extension_builder.h"
-#include "extensions/common/feature_switch.h"
#include "extensions/common/value_builder.h"
#include "ipc/ipc_message_utils.h"
#include "testing/gmock/include/gmock/gmock.h"
@@ -98,15 +98,25 @@ TEST(DeclarativeContentActionTest, InvalidCreation) {
}
TEST(DeclarativeContentActionTest, ShowPageActionWithoutPageAction) {
- // Tests legacy behavior.
- FeatureSwitch::ScopedOverride action_redesign_override(
- FeatureSwitch::extension_action_redesign(), false);
TestExtensionEnvironment env;
- const Extension* extension = env.MakeExtension(base::DictionaryValue());
+ // We install a component extension because all other extensions have a
+ // required action.
+ DictionaryBuilder manifest;
+ manifest.Set("name", "extension")
+ .Set("version", "0.1")
+ .Set("manifest_version", 2)
+ .Set("description", "an extension");
+ scoped_refptr<const Extension> extension =
+ ExtensionBuilder()
+ .SetManifest(manifest.Build())
+ .SetLocation(Manifest::COMPONENT)
+ .Build();
+ env.GetExtensionService()->AddExtension(extension.get());
+
std::string error;
std::unique_ptr<const ContentAction> result = ContentAction::Create(
- NULL, extension,
+ NULL, extension.get(),
*ParseJson("{\n"
" \"instanceType\": \"declarativeContent.ShowPageAction\",\n"
"}"),
« no previous file with comments | « no previous file | chrome/browser/extensions/api/declarative_content/declarative_content_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698