Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2675183005: MD Settings: Adjust icon ripples and row sizing. (Closed)

Created:
3 years, 10 months ago by scottchen
Modified:
3 years, 10 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Adjust icon ripples and row sizing. BUG=684152 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2675183005 Cr-Commit-Position: refs/heads/master@{#448854} Committed: https://chromium.googlesource.com/chromium/src/+/fc09866f18c741c81b93c9314829a3046c724128

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M chrome/browser/resources/settings/settings_vars_css.html View 2 chunks +13 lines, -5 lines 2 comments Download

Messages

Total messages: 14 (9 generated)
scottchen
3 years, 10 months ago (2017-02-06 23:33:55 UTC) #4
dschuyler
LGTM with a question https://codereview.chromium.org/2675183005/diff/1/chrome/browser/resources/settings/settings_vars_css.html File chrome/browser/resources/settings/settings_vars_css.html (right): https://codereview.chromium.org/2675183005/diff/1/chrome/browser/resources/settings/settings_vars_css.html#newcode44 chrome/browser/resources/settings/settings_vars_css.html:44: --settings-box-min-height: 45px; I'm a bit ...
3 years, 10 months ago (2017-02-07 21:22:41 UTC) #8
scottchen
https://codereview.chromium.org/2675183005/diff/1/chrome/browser/resources/settings/settings_vars_css.html File chrome/browser/resources/settings/settings_vars_css.html (right): https://codereview.chromium.org/2675183005/diff/1/chrome/browser/resources/settings/settings_vars_css.html#newcode44 chrome/browser/resources/settings/settings_vars_css.html:44: --settings-box-min-height: 45px; On 2017/02/07 21:22:41, dschuyler wrote: > I'm ...
3 years, 10 months ago (2017-02-08 00:23:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675183005/1
3 years, 10 months ago (2017-02-08 00:24:17 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 02:09:10 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc09866f18c741c81b93c9314829...

Powered by Google App Engine
This is Rietveld 408576698