MD Settings: Adjust icon ripples and row sizing.

MD Settings: Adjust icon ripples and row sizing.

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2675183005
Cr-Commit-Position: refs/heads/master@{#448854}
Committed: https://chromium.googlesource.com/chromium/src/+/fc09866f18c741c81b93c9314829a3046c724128

[scottchen, 2017-02-06 23:33:29]

Description was changed from

==========
MD Settings: Adjust icon ripples and row sizing.

BUG=684152
==========

to

==========
MD Settings: Adjust icon ripples and row sizing.

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[scottchen, 2017-02-06 23:33:41]

The CQ bit was checked by scottchen@chromium.org to run a CQ dry run

[scottchen, 2017-02-06 23:33:54]

scottchen@chromium.org changed reviewers:
+ dschuyler@chromium.org

[commit-bot: I haz the power, 2017-02-06 23:34:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 00:58:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 00:58:06]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2017-02-07 21:22:41]

LGTM with a question

https://codereview.chromium.org/2675183005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2675183005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_vars_css.html:44:
--settings-box-min-height: 45px;
I'm a bit concerned that changing from an even to an odd row height may case our
(centered) svg icons to render on half-pixel alignment and look fuzzy/blurry. If
the row icons (such as content-settings) look the same then this may not be an
issue. Do they look ok?

[scottchen, 2017-02-08 00:23:23]

https://codereview.chromium.org/2675183005/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_vars_css.html (right):

https://codereview.chromium.org/2675183005/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_vars_css.html:44:
--settings-box-min-height: 45px;
On 2017/02/07 21:22:41, dschuyler wrote:
> I'm a bit concerned that changing from an even to an odd row height may case
our
> (centered) svg icons to render on half-pixel alignment and look fuzzy/blurry.
If
> the row icons (such as content-settings) look the same then this may not be an
> issue. Do they look ok?

Just checked on Mac and Goobuntu, on both machines they icon looks the same for
44px and 45px line-heights, so I think they'll look okay.

[scottchen, 2017-02-08 00:23:31]

The CQ bit was checked by scottchen@chromium.org

[commit-bot: I haz the power, 2017-02-08 00:24:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 02:08:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486513411713090, "parent_rev":
"f1fbe08e33f617ef153c305b2af58e2f130767b2", "commit_rev":
"fc09866f18c741c81b93c9314829a3046c724128"}

[commit-bot: I haz the power, 2017-02-08 02:09:09]

Description was changed from

==========
MD Settings: Adjust icon ripples and row sizing.

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Adjust icon ripples and row sizing.

BUG=684152
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2675183005
Cr-Commit-Position: refs/heads/master@{#448854}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc09866f18c741c81b93c9314829...
==========

[commit-bot: I haz the power, 2017-02-08 02:09:10]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc09866f18c741c81b93c9314829...