Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2620)

Unified Diff: chrome/browser/resources/settings/settings_vars_css.html

Issue 2675183005: MD Settings: Adjust icon ripples and row sizing. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/settings_vars_css.html
diff --git a/chrome/browser/resources/settings/settings_vars_css.html b/chrome/browser/resources/settings/settings_vars_css.html
index 0cdbeb2a135e462fa32c09b4bd5c34bf5f9f374a..8c22a9539bc7df722fcb80a89aff6f6353ab7ed3 100644
--- a/chrome/browser/resources/settings/settings_vars_css.html
+++ b/chrome/browser/resources/settings/settings_vars_css.html
@@ -32,14 +32,16 @@
--settings-page-vertical-margin: 21px;
+ /* TODO (scottchen): re-implement with paddings instead; */
/* These are used for row items such as radio buttons, check boxes, list
* items etc. */
- --settings-row-min-height: 44px;
- --settings-row-two-line-min-height: 56px;
+ --settings-row-min-height: 45px;
+ --settings-row-two-line-min-height: 64px;
+ /* TODO (scottchen): re-implement with paddings instead; */
/* These are used for the settings-box containers, which may contain one or
* more "row items". */
- --settings-box-min-height: 48px;
+ --settings-box-min-height: 45px;
dschuyler 2017/02/07 21:22:41 I'm a bit concerned that changing from an even to
scottchen 2017/02/08 00:23:23 Just checked on Mac and Goobuntu, on both machines
--settings-box-two-line-min-height: 64px;
--settings-box-three-line-min-height: 84px;
@@ -85,9 +87,15 @@
--iron-icon-width: var(--cr-icon-size);
--paper-checkbox-label-color: inherit;
--paper-dialog-color: inherit;
+
+ --cr-icon-ripple-size: 40px;
--paper-icon-button: {
- height: var(--cr-icon-ripple-size);
- width: var(--cr-icon-ripple-size);
+ /**
+ * This makes the icons 20px (in combination with "--cr-icon-ripple-size:
+ * 40px"), since paper-icon-button>iron-icon width and height are
+ * hardcoded to 100%.
+ */
+ padding: 10px;
};
--paper-input-container-focus-color: var(--google-blue-500);
--paper-input-container-input: {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698