Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 2675183004: [Payments] Add extra comments to explain implicit usage of the animation duration (Closed)

Created:
3 years, 10 months ago by gogerald1
Modified:
3 years, 10 months ago
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add extra comments to explain implicit usage of the animation duration BUG=685771 Review-Url: https://codereview.chromium.org/2675183004 Cr-Commit-Position: refs/heads/master@{#448415} Committed: https://chromium.googlesource.com/chromium/src/+/a3a75cb7e4842e3b2e8f9ccc964cc17622ed1d7e

Patch Set 1 #

Total comments: 2

Patch Set 2 : move place #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
gogerald1
Hi rouslan@, PTAL,
3 years, 10 months ago (2017-02-06 21:05:29 UTC) #4
please use gerrit instead
lgtm % comment https://codereview.chromium.org/2675183004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java (right): https://codereview.chromium.org/2675183004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java#newcode1254 chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:1254: // the screen when triggering payment ...
3 years, 10 months ago (2017-02-06 21:09:51 UTC) #6
gogerald1
https://codereview.chromium.org/2675183004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java (right): https://codereview.chromium.org/2675183004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java#newcode1254 chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java:1254: // the screen when triggering payment and thus authorizing ...
3 years, 10 months ago (2017-02-06 21:44:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675183004/20001
3 years, 10 months ago (2017-02-06 21:45:18 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 22:28:02 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a3a75cb7e4842e3b2e8f9ccc964c...

Powered by Google App Engine
This is Rietveld 408576698