Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4329)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java

Issue 2675183004: [Payments] Add extra comments to explain implicit usage of the animation duration (Closed)
Patch Set: move place Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
index 5bdcbc66827fc53812053cf70a775b706c83e016..b2273b0bd30c019f47406afad33e3e02888292ac 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentRequestUI.java
@@ -284,7 +284,12 @@ public class PaymentRequestUI implements DialogInterface.OnDismissListener, View
}
}
- /** Length of the animation to either show the UI or expand it to full height. */
+ /**
+ * Length of the animation to either show the UI or expand it to full height.
+ * Note that click of 'Pay' button is not accepted until the animation is done, so this duration
+ * also serves the function of preventing the user from accidently double-clicking on the screen
+ * when triggering payment and thus authorizing unwanted transaction.
+ */
private static final int DIALOG_ENTER_ANIMATION_MS = 225;
/** Length of the animation to hide the bottom sheet UI. */
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698