Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2675133004: Add HTTP-specific metrics for password forms (Closed)

Created:
3 years, 10 months ago by estark
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Add HTTP-specific metrics for password forms These metrics will help us track the effect of the Form-Not-Secure warnings (which show a "Login not secure" message in the autofill dropdown on HTTP pages). BUG=677291 Review-Url: https://codereview.chromium.org/2667983006 Cr-Commit-Position: refs/heads/master@{#447867} (cherry picked from commit 0cd28be01ef0b1f4a51d2806c4601264a53d4c53) Review-Url: https://codereview.chromium.org/2675133004 . Cr-Commit-Position: refs/branch-heads/2987@{#338} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/9fc74678d1552a00425b8a591b540464ccd0f82c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M chrome/browser/password_manager/chrome_password_manager_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_form_manager.cc View 3 chunks +13 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/password_manager/core/browser/password_manager_client.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
estark
3 years, 10 months ago (2017-02-06 19:08:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9fc74678d1552a00425b8a591b540464ccd0f82c.

Powered by Google App Engine
This is Rietveld 408576698