components/password_manager/core/browser/password_manager_client.h - Issue 2675133004: Add HTTP-specific metrics for password forms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_client.h

Issue 2675133004: Add HTTP-specific metrics for password forms (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/password_manager/core/browser/password_manager_client.h

diff --git a/components/password_manager/core/browser/password_manager_client.h b/components/password_manager/core/browser/password_manager_client.h

index f0dfd13c56a4dc79ab71123fa2f0f1072edcb89b..714677019bdc0eee8eaea2537fc6be91ee3a6e87 100644

--- a/components/password_manager/core/browser/password_manager_client.h

+++ b/components/password_manager/core/browser/password_manager_client.h

@@ -184,6 +184,9 @@ class PasswordManagerClient {

// Returns the main frame URL.

virtual const GURL& GetMainFrameURL() const;

+ // Returns true if the main frame URL has a secure origin.

+ virtual bool IsMainFrameSecure() const;

virtual const GURL& GetLastCommittedEntryURL() const = 0;

// Use this to filter credentials before handling them in password manager.