Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2675133003: [string] Don't tail-call into runtime with adaptor frames (Closed)

Created:
3 years, 10 months ago by jgruber
Modified:
3 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[string] Don't tail-call into runtime with adaptor frames TailCallRuntime currently does not seem to handle adaptor frames correctly. BUG=chromium:688690 Review-Url: https://codereview.chromium.org/2675133003 Cr-Commit-Position: refs/heads/master@{#42950} Committed: https://chromium.googlesource.com/v8/v8/+/9576d08c92d30b49361e662113643b782e45ee49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M src/builtins/builtins-string.cc View 1 chunk +3 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-688690.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jgruber
3 years, 10 months ago (2017-02-06 09:41:31 UTC) #4
Igor Sheludko
lgtm
3 years, 10 months ago (2017-02-06 09:44:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2675133003/1
3 years, 10 months ago (2017-02-06 09:46:20 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 09:48:01 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9576d08c92d30b49361e662113643b782e4...

Powered by Google App Engine
This is Rietveld 408576698