Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: src/builtins/builtins-string.cc

Issue 2675133003: [string] Don't tail-call into runtime with adaptor frames (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-688690.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-string.cc
diff --git a/src/builtins/builtins-string.cc b/src/builtins/builtins-string.cc
index dddd32a8cd04a1c78ccf6a159e91df86d343f1e1..e9dd140d3c7a4552fffe9bbf8ca981e1d7cbabdc 100644
--- a/src/builtins/builtins-string.cc
+++ b/src/builtins/builtins-string.cc
@@ -1197,8 +1197,9 @@ TF_BUILTIN(StringPrototypeReplace, StringBuiltinsAssembler) {
// slices works only when the replaced string is a single character, being
// replaced by a simple string and only pays off for long strings.
// TODO(jgruber): Reevaluate if this is still beneficial.
- TailCallRuntime(Runtime::kStringReplaceOneCharWithString, context,
- subject_string, search_string, replace);
+ // TODO(jgruber): TailCallRuntime when it correctly handles adapter frames.
+ Return(CallRuntime(Runtime::kStringReplaceOneCharWithString, context,
+ subject_string, search_string, replace));
Bind(&next);
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-688690.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698