Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: components/safe_browsing_db/v4_get_hash_protocol_manager.h

Issue 2675063002: Browser tests for using the new SafeBrowsing protocol (v4) (Closed)
Patch Set: shess@'s review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/v4_get_hash_protocol_manager.h
diff --git a/components/safe_browsing_db/v4_get_hash_protocol_manager.h b/components/safe_browsing_db/v4_get_hash_protocol_manager.h
index ffd4ea89056579c54b30114ea98269a010231af1..8a0f855da504051de934ce083b12ba1246e2802e 100644
--- a/components/safe_browsing_db/v4_get_hash_protocol_manager.h
+++ b/components/safe_browsing_db/v4_get_hash_protocol_manager.h
@@ -288,6 +288,10 @@ class V4GetHashProtocolManager : public net::URLFetcherDelegate,
const std::vector<FullHashInfo>& full_hash_infos,
const base::Time& negative_cache_expire);
+ protected:
+ // A cache of full hash results.
Nathan Parker 2017/02/08 01:22:54 Is this protected for tests? It might be better to
+ FullHashCache full_hash_cache_;
+
private:
// Map of GetHash requests to parameters which created it.
using PendingHashRequests =
@@ -329,9 +333,6 @@ class V4GetHashProtocolManager : public net::URLFetcherDelegate,
// The clock used to vend times.
std::unique_ptr<base::Clock> clock_;
- // A cache of full hash results.
- FullHashCache full_hash_cache_;
-
// The following sets represent the combination of lists that we would always
// request from the server, irrespective of which list we found the hash
// prefix match in.

Powered by Google App Engine
This is Rietveld 408576698