Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: components/safe_browsing_db/v4_feature_list.cc

Issue 2675063002: Browser tests for using the new SafeBrowsing protocol (v4) (Closed)
Patch Set: shess@'s review Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_browsing_db/v4_feature_list.cc
diff --git a/components/safe_browsing_db/v4_feature_list.cc b/components/safe_browsing_db/v4_feature_list.cc
index 323ad4db74f396de0e85e3b07dd198e6735764ec..4816d0eeeca6ca16009aa7af264ab6925190555b 100644
--- a/components/safe_browsing_db/v4_feature_list.cc
+++ b/components/safe_browsing_db/v4_feature_list.cc
@@ -9,7 +9,6 @@ namespace safe_browsing {
namespace V4FeatureList {
-namespace {
const base::Feature kLocalDatabaseManagerEnabled{
"SafeBrowsingV4LocalDatabaseManagerEnabled",
base::FEATURE_DISABLED_BY_DEFAULT};
@@ -20,8 +19,6 @@ const base::Feature kV4HybridEnabled{"SafeBrowsingV4HybridEnabled",
const base::Feature kV4OnlyEnabled{"SafeBrowsingV4OnlyEnabled",
base::FEATURE_DISABLED_BY_DEFAULT};
-} // namespace
-
bool IsLocalDatabaseManagerEnabled() {
return base::FeatureList::IsEnabled(kLocalDatabaseManagerEnabled) ||
IsV4HybridEnabled() || IsV4OnlyEnabled();
@@ -32,8 +29,6 @@ bool IsV4HybridEnabled() {
}
bool IsV4OnlyEnabled() {
- // TODO(vakh): Enable this only when all the lists can be synced from the
- // server. See http://b/33182208
return base::FeatureList::IsEnabled(kV4OnlyEnabled);
}

Powered by Google App Engine
This is Rietveld 408576698