Browser tests for using the new SafeBrowsing protocol (v4)

components/safe_browsing_db/v4_get_hash_protocol_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SAFE_BROWSING_DB_V4_GET_HASH_PROTOCOL_MANAGER_H_
 #define COMPONENTS_SAFE_BROWSING_DB_V4_GET_HASH_PROTOCOL_MANAGER_H_
 
 // A class that implements Chrome's interface with the SafeBrowsing V4 protocol.
 //
 // The V4GetHashProtocolManager handles formatting and making requests of, and
@@ skipping 270 matching lines @@
 
   // Overrides the clock used to check the time.
   void SetClockForTests(std::unique_ptr<base::Clock> clock);
 
   // Updates the state of the full hash cache upon receiving a valid response
   // from the server.
   void UpdateCache(const std::vector<HashPrefix>& prefixes_requested,
                    const std::vector<FullHashInfo>& full_hash_infos,
                    const base::Time& negative_cache_expire);
 
+ protected:
+  // A cache of full hash results.

[Nathan Parker, 2017/02/08 01:22:54]

Is this protected for tests? It might be better to just make them friends.  Or
comment on why this is protected.

+  FullHashCache full_hash_cache_;
+
  private:
   // Map of GetHash requests to parameters which created it.
   using PendingHashRequests =
       base::hash_map<const net::URLFetcher*,
                      std::unique_ptr<FullHashCallbackInfo>>;
 
   // The factory that controls the creation of V4GetHashProtocolManager.
   // This is used by tests.
   static V4GetHashProtocolManagerFactory* factory_;
 
@@ skipping 21 matching lines @@
 
   // The context we use to issue network requests.
   scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
 
   // ID for URLFetchers for testing.
   int url_fetcher_id_;
 
   // The clock used to vend times.
   std::unique_ptr<base::Clock> clock_;
 
-  // A cache of full hash results.
-  FullHashCache full_hash_cache_;
-
   // The following sets represent the combination of lists that we would always
   // request from the server, irrespective of which list we found the hash
   // prefix match in.
   std::vector<PlatformType> platform_types_;
   std::vector<ThreatEntryType> threat_entry_types_;
   std::vector<ThreatType> threat_types_;
 
   DISALLOW_COPY_AND_ASSIGN(V4GetHashProtocolManager);
 };
 
@@ skipping 11 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(V4GetHashProtocolManagerFactory);
 };
 
 #ifndef NDEBUG
 std::ostream& operator<<(std::ostream& os, const FullHashInfo& id);
 #endif
 
 }  // namespace safe_browsing
 
 #endif  // COMPONENTS_SAFE_BROWSING_DB_V4_GET_HASH_PROTOCOL_MANAGER_H_