Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2674913004: Fix windows margin scaling bug (Closed)

Created:
3 years, 10 months ago by rbpotter
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix windows margin scaling bug When printing to local printers Windows uses the computed page size. Page size is scaled when using print scaling to force blink to reflow the page. Need to unscale the page size before sending it back to Windows so that Windows knows the correct page size. BUG=686384 Review-Url: https://codereview.chromium.org/2667793002 Cr-Commit-Position: refs/heads/master@{#447647} (cherry picked from commit 8f96566d8d7d712d4d11ca04e4f3641048362276) Review-Url: https://codereview.chromium.org/2674913004 . Cr-Commit-Position: refs/branch-heads/2987@{#305} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/97411fe06ea6c9f953b5944b73eb7920999df16b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M components/printing/renderer/print_web_view_helper.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
rbpotter
3 years, 10 months ago (2017-02-03 23:04:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
97411fe06ea6c9f953b5944b73eb7920999df16b.

Powered by Google App Engine
This is Rietveld 408576698