Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2667793002: Fix windows margin scaling bug (Closed)

Created:
3 years, 10 months ago by rbpotter
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix windows margin scaling bug When printing to local printers Windows uses the computed page size. Page size is scaled when using print scaling to force blink to reflow the page. Need to unscale the page size before sending it back to Windows so that Windows knows the correct page size. BUG=686384 Review-Url: https://codereview.chromium.org/2667793002 Cr-Commit-Position: refs/heads/master@{#447647} Committed: https://chromium.googlesource.com/chromium/src/+/8f96566d8d7d712d4d11ca04e4f3641048362276

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M components/printing/renderer/print_web_view_helper.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
rbpotter
3 years, 10 months ago (2017-01-30 23:15:33 UTC) #5
rbpotter
3 years, 10 months ago (2017-01-31 19:28:59 UTC) #8
rbpotter
3 years, 10 months ago (2017-02-01 21:25:37 UTC) #9
Vitaly Buka (NO REVIEWS)
LGTM how does it work for linux or chromeos?
3 years, 10 months ago (2017-02-01 22:50:36 UTC) #10
rbpotter
On 2017/02/01 22:50:36, Vitaly Buka wrote: > LGTM > how does it work for linux ...
3 years, 10 months ago (2017-02-01 22:52:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2667793002/1
3 years, 10 months ago (2017-02-01 22:53:46 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 23:56:30 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8f96566d8d7d712d4d11ca04e4f3...

Powered by Google App Engine
This is Rietveld 408576698