Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
Review-Url: https://codereview.chromium.org/2674863003
Cr-Commit-Position: refs/heads/master@{#450712}
Committed: https://chromium.googlesource.com/chromium/src/+/69e724195bd12abab86bb08cdaff8ba0b31243a0

[zakerinasab, 2017-02-03 17:32:23]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions. The
expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

[zakerinasab, 2017-02-03 17:32:23]

zakerinasab@chromium.org changed reviewers:
+ junov@chromium.org

[zakerinasab, 2017-02-03 17:32:35]

CL uploaded. PTAL.

[Justin Novosad, 2017-02-09 20:32:01]

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-direction.html (right):

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-direction.html:57: var
newCanvasElement = document.createElement('canvas');
indent

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-direction.html:165:
verifyDrawText('canvas1', 'Left-to-Right text', 'ltr');
should use generate_tests

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-animated.html
(right):

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-animated.html:18:
test(function(t) {
Test may quit before this runs.  Please keep this an async test.

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-live-video.html
(right):

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-live-video.html:17:
test(function(t) {
why no longer async?

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-live-video.html:27:
function drawFirstFrame() {
Test ends before this is called.

[zakerinasab, 2017-02-13 16:25:19]

Comments addressed. New change list uploaded.

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-direction.html (right):

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-direction.html:57: var
newCanvasElement = document.createElement('canvas');
On 2017/02/09 20:32:01, Justin Novosad wrote:
> indent

Done.

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-direction.html:165:
verifyDrawText('canvas1', 'Left-to-Right text', 'ltr');
On 2017/02/09 20:32:01, Justin Novosad wrote:
> should use generate_tests

Done.

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-animated.html
(right):

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-animated.html:18:
test(function(t) {
On 2017/02/09 20:32:01, Justin Novosad wrote:
> Test may quit before this runs.  Please keep this an async test.

Done.

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-live-video.html
(right):

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-live-video.html:17:
test(function(t) {
On 2017/02/09 20:32:01, Justin Novosad wrote:
> why no longer async?

Done.

https://codereview.chromium.org/2674863003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-live-video.html:27:
function drawFirstFrame() {
On 2017/02/09 20:32:01, Justin Novosad wrote:
> Test ends before this is called.

Done.

[Justin Novosad, 2017-02-14 20:22:05]

lgtm with nit

https://codereview.chromium.org/2674863003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-direction.html (right):

https://codereview.chromium.org/2674863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-direction.html:174:
['DrawTextWithSpecifiedDirectionTest1',
This form is excellent. Very readable, well organized.

https://codereview.chromium.org/2674863003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-animated.html
(right):

https://codereview.chromium.org/2674863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-animated.html:11:
window.onload = function() {
Indent is weird.

[zakerinasab, 2017-02-15 14:53:02]

Nits addressed. Landing.

https://codereview.chromium.org/2674863003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-direction.html (right):

https://codereview.chromium.org/2674863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-direction.html:174:
['DrawTextWithSpecifiedDirectionTest1',
On 2017/02/14 20:22:04, Justin Novosad wrote:
> This form is excellent. Very readable, well organized.

Acknowledged.

https://codereview.chromium.org/2674863003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-animated.html
(right):

https://codereview.chromium.org/2674863003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/canvas/canvas-drawImage-animated.html:11:
window.onload = function() {
On 2017/02/14 20:22:05, Justin Novosad wrote:
> Indent is weird. 

Fixed.

[zakerinasab, 2017-02-15 14:53:08]

The CQ bit was checked by zakerinasab@chromium.org

[zakerinasab, 2017-02-15 14:53:08]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2674863003/#ps60001
(title: "Addressing comments")

[commit-bot: I haz the power, 2017-02-15 14:53:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 15:50:36]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1487170388007870,
"parent_rev": "d61bcad3017676cfbc1a53c65a51ffcef331b56e", "commit_rev":
"69e724195bd12abab86bb08cdaff8ba0b31243a0"}

[commit-bot: I haz the power, 2017-02-15 15:51:12]

Description was changed from

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732
==========

to

==========
Use testharness.js instead of js-test.js in LayoutTests/fast/canvas tests.

This change replaces js-test.js assertions with testharness.js assertions.
The expectation files are removed as they are not needed anymore.
To simplify review and landing, each change corrects 10 tests.

BUG=639732

Review-Url: https://codereview.chromium.org/2674863003
Cr-Commit-Position: refs/heads/master@{#450712}
Committed:
https://chromium.googlesource.com/chromium/src/+/69e724195bd12abab86bb08cdaff...
==========

[commit-bot: I haz the power, 2017-02-15 15:51:14]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/69e724195bd12abab86bb08cdaff...