Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2674783002: media: Pass CdmContext in decoder reinitialization (Closed)

Created:
3 years, 10 months ago by xhwang
Modified:
3 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

media: Pass CdmContext in decoder reinitialization Fix DecoderStream::ReinitializeDecoder to always pass in the CdmContext. Also added unittests to cover the case where neither DecryptionVideoDecoder nor DecryptingDemuxerStream is selected for encrypted config, but another VideoDecoder that supports encrypted config is selected, initialized, and reinitialized. In practice, this could be the case when the CDM doesn't support the Decryptor interface, e.g. MediaDrmBridge on Android. NOTRY=true NOPRESUBMIT=true TBR=dalecurtis@chromium.org BUG=679095 Review-Url: https://codereview.chromium.org/2650823006 Cr-Commit-Position: refs/heads/master@{#446190} (cherry picked from commit 95f1b49f981dd91d79c08d52481103f669db55f0) Review-Url: https://codereview.chromium.org/2674783002 . Cr-Commit-Position: refs/branch-heads/2987@{#281} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/b509b3c001a440d1972e49929d6a511242a18a26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -41 lines) Patch
M media/filters/decoder_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/fake_video_decoder.h View 2 chunks +5 lines, -0 lines 0 comments Download
M media/filters/fake_video_decoder.cc View 3 chunks +13 lines, -1 line 0 comments Download
M media/filters/video_frame_stream_unittest.cc View 6 chunks +51 lines, -39 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xhwang
3 years, 10 months ago (2017-02-02 21:03:13 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b509b3c001a440d1972e49929d6a511242a18a26.

Powered by Google App Engine
This is Rietveld 408576698