Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issue 2650823006: media: Pass CdmContext in decoder reinitialization (Closed)

Created:
3 years, 11 months ago by xhwang
Modified:
3 years, 11 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Pass CdmContext in decoder reinitialization Fix DecoderStream::ReinitializeDecoder to always pass in the CdmContext. Also added unittests to cover the case where neither DecryptionVideoDecoder nor DecryptingDemuxerStream is selected for encrypted config, but another VideoDecoder that supports encrypted config is selected, initialized, and reinitialized. In practice, this could be the case when the CDM doesn't support the Decryptor interface, e.g. MediaDrmBridge on Android. BUG=679095 Review-Url: https://codereview.chromium.org/2650823006 Cr-Commit-Position: refs/heads/master@{#446190} Committed: https://chromium.googlesource.com/chromium/src/+/95f1b49f981dd91d79c08d52481103f669db55f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -41 lines) Patch
M media/filters/decoder_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/filters/fake_video_decoder.h View 2 chunks +5 lines, -0 lines 0 comments Download
M media/filters/fake_video_decoder.cc View 3 chunks +13 lines, -1 line 0 comments Download
M media/filters/video_frame_stream_unittest.cc View 6 chunks +51 lines, -39 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
xhwang
PTAL
3 years, 11 months ago (2017-01-25 17:46:24 UTC) #6
DaleCurtis
lgtm
3 years, 11 months ago (2017-01-25 20:20:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2650823006/1
3 years, 11 months ago (2017-01-25 22:50:34 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 01:19:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/95f1b49f981dd91d79c08d524811...

Powered by Google App Engine
This is Rietveld 408576698