Issue 2674743002: Ensure field type is Payment before showing Payment Not Secure Warning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2674743002: Ensure field type is Payment before showing Payment Not Secure Warning (Closed)

Created:
3 years, 10 months ago by estark

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Ensure field type is Payment before showing Payment Not Secure Warning The Form Not Secure warning must verify that the form field belongs to a payment form before showing the "Payment Not Secure" warning. BUG=672663 Review-Url: https://codereview.chromium.org/2660473002 Cr-Commit-Position: refs/heads/master@{#446468} (cherry picked from commit 7563d11df963b1807dc96bc530a6a870fb1db222) Review-Url: https://codereview.chromium.org/2674743002 . Cr-Commit-Position: refs/branch-heads/2987@{#271} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/595def03304d70b51fddb4ccbd75f56339d4928c

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -1 line)			Patch
	M	components/autofill/core/browser/autofill_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	components/autofill/core/browser/autofill_manager_unittest.cc	View		1 chunk	+18 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

estark

3 years, 10 months ago (2017-02-02 18:40:44 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
595def03304d70b51fddb4ccbd75f56339d4928c.