Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2660473002: Ensure field type is Payment before showing Payment Not Secure Warning (Closed)

Created:
3 years, 11 months ago by elawrence
Modified:
3 years, 11 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, rogerm+autofillwatch_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, mathp+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure field type is Payment before showing Payment Not Secure Warning The Form Not Secure warning must verify that the form field belongs to a payment form before showing the "Payment Not Secure" warning. BUG=672663 Review-Url: https://codereview.chromium.org/2660473002 Cr-Commit-Position: refs/heads/master@{#446468} Committed: https://chromium.googlesource.com/chromium/src/+/7563d11df963b1807dc96bc530a6a870fb1db222

Patch Set 1 #

Patch Set 2 : Add unit test to detect regressions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M components/autofill/core/browser/autofill_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
elawrence
Can you please take a look at this tiny change? Wednesday's CL omitted an important ...
3 years, 11 months ago (2017-01-26 20:42:42 UTC) #5
elawrence
Can you please take a look at this tiny change? Wednesday's CL omitted an important ...
3 years, 11 months ago (2017-01-26 20:42:42 UTC) #6
Mathieu
lgtm
3 years, 11 months ago (2017-01-26 22:07:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660473002/20001
3 years, 11 months ago (2017-01-26 22:10:07 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 22:16:27 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7563d11df963b1807dc96bc530a6...

Powered by Google App Engine
This is Rietveld 408576698