Issue 2674653002: KeyedStoreGeneric: make fast-property stores use the stub cache again

Issue 2674653002: KeyedStoreGeneric: make fast-property stores use the stub cache again (Closed)

Created:
3 years, 10 months ago by Jakob Kummerow

Modified:
3 years, 10 months ago

Reviewers:
danno

CC:
v8-reviews_googlegroups.com

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

KeyedStoreGeneric: make fast-property stores use the stub cache again This behavior was recently changed. Turns out that for some usage patterns at least, populating the stub cache is significantly faster overall. BUG=chromium:684428 Review-Url: https://codereview.chromium.org/2674653002 Cr-Commit-Position: refs/heads/master@{#42885} Committed: https://chromium.googlesource.com/v8/v8/+/c85ff828228c6697424ec2e69c691da7d46e132d

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	src/ic/keyed-store-generic.cc	View		1 chunk	+9 lines, -6 lines	0 comments	Download

Total messages: 8 (4 generated)

Jakob Kummerow

This partial revert restores speedometer/react performance in local testing.

3 years, 10 months ago (2017-02-02 07:04:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674653002/1

3 years, 10 months ago (2017-02-02 11:44:16 UTC) #5

commit-bot: I haz the power

3 years, 10 months ago (2017-02-02 12:37:48 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/c85ff828228c6697424ec2e69c691da7d46...