KeyedStoreGeneric: make fast-property stores use the stub cache again

src/ic/keyed-store-generic.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/ic/keyed-store-generic.h"
 
 #include "src/code-factory.h"
 #include "src/code-stub-assembler.h"
 #include "src/contexts.h"
 #include "src/ic/accessor-assembler.h"
@@ skipping 711 matching lines @@
                       type, p->receiver);
     } else {
       DCHECK_EQ(SLOPPY, language_mode);
       Return(p->value);
     }
   }
 
   Bind(&stub_cache);
   {
     Comment("stub cache probe");
-    // The stub cache lookup is opportunistic: if we find a handler, use it;
-    // otherwise take the slow path. Since this is a generic stub, compiling
-    // a handler (as KeyedStoreIC_Miss would do) is probably a waste of time.
     Variable var_handler(this, MachineRepresentation::kTagged);
-    Label found_handler(this, &var_handler);
+    Label found_handler(this, &var_handler), stub_cache_miss(this);
     TryProbeStubCache(isolate()->store_stub_cache(), receiver, p->name,
-                      &found_handler, &var_handler, slow);
+                      &found_handler, &var_handler, &stub_cache_miss);
     Bind(&found_handler);
     {
       Comment("KeyedStoreGeneric found handler");
-      HandleStoreICHandlerCase(p, var_handler.value(), slow);
+      HandleStoreICHandlerCase(p, var_handler.value(), &stub_cache_miss);
+    }
+    Bind(&stub_cache_miss);
+    {
+      Comment("KeyedStoreGeneric_miss");
+      TailCallRuntime(Runtime::kKeyedStoreIC_Miss, p->context, p->value,
+                      p->slot, p->vector, p->receiver, p->name);
     }
   }
 }
 
 void KeyedStoreGenericAssembler::KeyedStoreGeneric(LanguageMode language_mode) {
   typedef StoreWithVectorDescriptor Descriptor;
 
   Node* receiver = Parameter(Descriptor::kReceiver);
   Node* name = Parameter(Descriptor::kName);
   Node* value = Parameter(Descriptor::kValue);
@@ skipping 35 matching lines @@
   Bind(&slow);
   {
     Comment("KeyedStoreGeneric_slow");
     TailCallRuntime(Runtime::kSetProperty, context, receiver, name, value,
                     SmiConstant(language_mode));
   }
 }
 
 }  // namespace internal
 }  // namespace v8