Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1149)

Issue 2674573006: [DevTools] Migrate TargetObserver to AnimationModel observer where makes sense. (Closed)

Created:
3 years, 10 months ago by dgozman
Modified:
3 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, darktears, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Migrate TargetObserver to AnimationModel observer where makes sense. Some observers are not actually interested in targets, but rather all the models. BUG=none Review-Url: https://codereview.chromium.org/2674573006 Cr-Commit-Position: refs/heads/master@{#447943} Committed: https://chromium.googlesource.com/chromium/src/+/3e2c17f370ca181263aa6b6342c8d991f216e62c

Patch Set 1 #

Messages

Total messages: 11 (7 generated)
dgozman
Take a look please.
3 years, 10 months ago (2017-02-03 01:17:15 UTC) #2
pfeldman
lgtm
3 years, 10 months ago (2017-02-03 01:20:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2674573006/1
3 years, 10 months ago (2017-02-03 02:19:01 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 04:52:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3e2c17f370ca181263aa6b6342c8...

Powered by Google App Engine
This is Rietveld 408576698