Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2672983002: [DevTools] Separate ScreenCaptureModel out of ResourceTreeModel. (Closed)

Created:
3 years, 10 months ago by dgozman
Modified:
3 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, shans, rjwright, blink-reviews-animation_chromium.org, darktears, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Separate ScreenCaptureModel out of ResourceTreeModel. This ensures proper use of the agent and capability check. BUG=none Review-Url: https://codereview.chromium.org/2672983002 Cr-Commit-Position: refs/heads/master@{#450571} Committed: https://chromium.googlesource.com/chromium/src/+/5537284b4c9430698274f1dca75ee12d5dbd6e59

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -90 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js View 6 chunks +14 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/ScreencastApp.js View 3 chunks +20 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/ScreencastView.js View 7 chunks +28 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/screencast/module.json View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js View 4 chunks +5 lines, -9 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/sdk/ScreenCaptureModel.js View 1 chunk +192 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Target.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/module.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
dgozman
What do you think about this?
3 years, 10 months ago (2017-02-03 02:46:34 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/2672983002/diff/1/third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js File third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js (right): https://codereview.chromium.org/2672983002/diff/1/third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js#newcode717 third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js:717: for (var index = 0; index < this._dispatchers.length; ...
3 years, 10 months ago (2017-02-03 03:01:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2672983002/20001
3 years, 10 months ago (2017-02-14 22:36:54 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 05:52:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5537284b4c9430698274f1dca75e...

Powered by Google App Engine
This is Rietveld 408576698